[#48216] - [5.4] site offline
- Fixed in Code Base
- 8 Aug 2026
- Medium
- Build: 5.4-dev
- # 48216
- Diff
- brianteeman:siteoffline
User tests: Successful: Unsuccessful:
Pull Request resolves #48094 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
resolve deprecated message on cassiopeia offline
Using trim() instead because you're really checking whether the message contains anything meaningful, rather than specifically removing ordinary spaces. It also handles tabs and newlines.
Testing Instructions
- Enable php max reporting
- Set the site offline
- Offline message = Use custom message"
- Empty the field Custom Message
- Visit front end
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
After applying the PR the deprecated message is not displayed
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 6dfafa9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48216.
I have tested this item ✅ successfully on 6dfafa9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48216.
I have tested this item ✅ successfully on 6dfafa9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48216.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48216.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48216.
Thanks
| Labels |
Added:
RTC
bug
|
||
✅ Final test before merge with JBT
- Seen
Deprecated: str_replace(): Passing null to parameterbefore PR - Applied PR with Patch Tester
- Deprecation error for empty custom offline message is gone
- Custom offline message is still working
- Hide offline message is still working
- Site language default message is still working
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-08 15:02:05 |
| Closed_By | ⇒ | muhme |
Thank you very much @brianteeman for your contribution. Thanks to @richard67 and @SniperSister for testing.
Thanks
I have tested this item ✅ successfully on 6dfafa9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48216.