? Success
Related to # 4168

User tests: Successful: Unsuccessful:

avatar kochinc
kochinc
18 Oct 2014

This is an attempt to address Issue #4168.
The modifications allow show_page_heading for a menu item to be set to JGLOBAL_USE_GLOBAL, JYES or JNO. When it is set to JGLOBAL_USE_GLOBAL, com_menu's global show_page_heading setting is used when display the page.

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar kochinc kochinc - open - 18 Oct 2014
avatar jissues-bot jissues-bot - change - 18 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 18 Oct 2014
Rel_Number 4168
Relation Type Related to
avatar infograf768
infograf768 - comment - 18 Oct 2014

Code style please:
FILE: /home/travis/build/joomla/joomla-cms/libraries/cms/application/site.php


FOUND 2 ERROR(S) AFFECTING 2 LINE(S)


349 | ERROR | Whitespace found at end of line

354 | ERROR | Whitespace found at end of line

avatar sovainfo
sovainfo - comment - 18 Oct 2014

Created PR for @kochinc

avatar twsnikhil twsnikhil - test_item - 18 Oct 2014 - Tested successfully
avatar roland-d
roland-d - comment - 14 Nov 2014

@kochinc Can you please fix the merge conflict so I can test it? Thanks.

avatar kochinc
kochinc - comment - 16 Nov 2014

@roland-d I merged the upstream/staging to my staging and fixed the conflict. But for some reason the merge also deleted the file tests/unit/suites/libraries/joomla/document/xml/JDocumentXmlTest.php. That deletion shouldn't be in the pull request.

avatar roland-d roland-d - test_item - 24 Nov 2014 - Tested successfully
avatar roland-d
roland-d - comment - 24 Nov 2014

@test successful after applying the patch, the global settings are taken into account.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4819.

avatar roland-d roland-d - change - 27 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 27 Nov 2014

Moving to RTC, has 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4819.

avatar brianteeman brianteeman - change - 29 Nov 2014
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Dec 2014
avatar wilsonge wilsonge - change - 14 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-14 01:02:12
avatar wilsonge
wilsonge - comment - 14 Dec 2014

Manually applied patch to deal with the unintentionally deleted file. Thanks!

Add a Comment

Login with GitHub to post a comment