? Success

User tests: Successful: Unsuccessful:

avatar FriendlyHacker
FriendlyHacker
18 Oct 2014

.

avatar FriendlyHacker FriendlyHacker - open - 18 Oct 2014
avatar jissues-bot jissues-bot - change - 18 Oct 2014
Labels Added: ?
avatar brianteeman
brianteeman - comment - 18 Oct 2014

Please provide a description of what problem this PR is aiming to resolve. How someone can test it etc. As it is no one has a clue what it is and it will not get tested please see https://github.com/joomla/joomla-cms/blob/staging/CONTRIBUTING.md

I am setting this to information required and it will be closed in a few weeks if the information is not provided - thanks for you understanding

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4818.

avatar brianteeman brianteeman - change - 18 Oct 2014
The description was changed
Status Pending Information Required
avatar losedk
losedk - comment - 18 Oct 2014

Actually some fine additions, but you should avoid !important and you need to update the less file as well

avatar dgt41
dgt41 - comment - 18 Oct 2014

@losedk Joomla uses the same trick with !important here https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L7409 For this case it’s not bad in my opinion

avatar dgt41
dgt41 - comment - 18 Oct 2014

@FriendlyHacker You have to make the changes in the less files (/isis/less/template.less etc). Also for rtl stylesheet. and then from terminal run the generates.php which is located at (your path to htdocs)/build/

avatar RCheesley
RCheesley - comment - 25 Oct 2014

Test instructions would be helpful please?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4818.

avatar dgt41
dgt41 - comment - 25 Oct 2014

@RCheesley Looking at the changes made here: you have to apply patch and then in administrator area with your browser really narrow (mobile view <480px) do some navigation and watch for dropdown menus, tables, navigation and input fields. They should be aligned (I think)...

avatar brianteeman
brianteeman - comment - 1 Jan 2015

After considerable time without update I am closing this. If you feel this is still an issue please provide further information and it can always be reopened


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4818.
avatar brianteeman brianteeman - change - 1 Jan 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-01-01 16:57:07
Closed_By brianteeman
avatar brianteeman brianteeman - close - 1 Jan 2015

Add a Comment

Login with GitHub to post a comment