RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
31 Jul 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Smart Search uses a MEMORY table to store intermediate results from the indexing process before permanently adding them to the index. When the intermediate data gets to big, the table is switched from MEMORY to a normal INNODB. At one point we standardized the default value to 7500 entries, but missed one spot. While the value is written automatically upon start of indexing, this cleans up that one default-value-fallback. It has no actual effect on the code execution, but is basically just some code-hygiene. That is why this simply requires a code review.

Testing Instructions

Since this only brings the default value in line with all other default values, this can only be done via code review.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 31 Jul 2026
avatar Hackwar Hackwar - change - 31 Jul 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2026
Category Administration com_finder
avatar brianteeman
brianteeman - comment - 31 Jul 2026

Just checking that this is still ok

$data->options->set('memory_table_limit', 50000);

avatar Hackwar
Hackwar - comment - 31 Jul 2026

Yes, that is still fine. Postgres doesn't have that issue and even for MySQL I'm looking if there is a better solution. But one step after the other.

avatar brianteeman brianteeman - test_item - 31 Jul 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Jul 2026

I have tested this item ✅ successfully on 8eb0183


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48173.

avatar brianteeman
brianteeman - comment - 31 Jul 2026

I have tested this item ✅ successfully on 8eb0183


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48173.

avatar QuyTon QuyTon - test_item - 31 Jul 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 31 Jul 2026

I have tested this item ✅ successfully on 8eb0183


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48173.

avatar QuyTon
QuyTon - comment - 31 Jul 2026

I have tested this item ✅ successfully on 8eb0183


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48173.

avatar QuyTon QuyTon - change - 31 Jul 2026
Status Pending Ready to Commit
Labels Added: PR-5.4-dev
avatar QuyTon
QuyTon - comment - 31 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48173.

avatar QuyTon
QuyTon - comment - 31 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48173.

avatar richard67 richard67 - change - 31 Jul 2026
Labels Added: RTC
avatar richard67 richard67 - change - 31 Jul 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-07-31 20:34:27
Closed_By richard67
avatar richard67 richard67 - close - 31 Jul 2026
avatar richard67 richard67 - merge - 31 Jul 2026
avatar richard67
richard67 - comment - 31 Jul 2026

Thanks @Hackwar for this PR, and @brianteeman and @QuyTon for testing.

Add a Comment

Login with GitHub to post a comment