User tests: Successful: Unsuccessful:
This PR changes the usages of path::clean to path::check in the template manager. The key difference is, that path::check disallows relative paths and thereby prevents path traversals.
This is not supposed to be a security fix: the template manager is limited to super admins only and by definition allows code editing and therefore code execution. However, the JSST gets reports to those missing traversal checks over and over (AI huh, what a time to be alive) and tbh I'm not willing to waste any further resources replying to those reports. So let's convert clean to check.
Verify that the template manager file actions (edit, save, rename, delete, extract zip) work as before hand
Works
Works
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_templates |
I have tested this item ✅ successfully on 294c3e9
I have tested this item ✅ successfully on 294c3e9
I have tested this item ✅ successfully on 294c3e9
looks like the automated tests need to be re-run
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.4-dev
|
||
RTC
RTC
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-31 21:26:47 |
| Closed_By | ⇒ | richard67 |
Thanks @SniperSister for your PR, @tecpromotion for review, and @brianteeman and @ThomasFinnern for testing.
I have tested this item ✅ successfully on 294c3e9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.