RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
31 Jul 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This PR changes the usages of path::clean to path::check in the template manager. The key difference is, that path::check disallows relative paths and thereby prevents path traversals.

This is not supposed to be a security fix: the template manager is limited to super admins only and by definition allows code editing and therefore code execution. However, the JSST gets reports to those missing traversal checks over and over (AI huh, what a time to be alive) and tbh I'm not willing to waste any further resources replying to those reports. So let's convert clean to check.

Testing Instructions

Verify that the template manager file actions (edit, save, rename, delete, extract zip) work as before hand

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 31 Jul 2026
avatar SniperSister SniperSister - change - 31 Jul 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2026
Category Administration com_templates
avatar brianteeman brianteeman - test_item - 31 Jul 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Jul 2026

I have tested this item ✅ successfully on 294c3e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.

avatar brianteeman
brianteeman - comment - 31 Jul 2026

I have tested this item ✅ successfully on 294c3e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.

avatar ThomasFinnern ThomasFinnern - test_item - 31 Jul 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 31 Jul 2026

I have tested this item ✅ successfully on 294c3e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.

avatar ThomasFinnern
ThomasFinnern - comment - 31 Jul 2026

I have tested this item ✅ successfully on 294c3e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.

avatar brianteeman
brianteeman - comment - 31 Jul 2026

looks like the automated tests need to be re-run

avatar QuyTon QuyTon - change - 31 Jul 2026
Status Pending Ready to Commit
Labels Added: PR-5.4-dev
avatar QuyTon
QuyTon - comment - 31 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.

avatar QuyTon
QuyTon - comment - 31 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48171.

avatar richard67 richard67 - change - 31 Jul 2026
Labels Added: RTC
avatar richard67 richard67 - change - 31 Jul 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-07-31 21:26:47
Closed_By richard67
avatar richard67 richard67 - close - 31 Jul 2026
avatar richard67 richard67 - merge - 31 Jul 2026
avatar richard67
richard67 - comment - 31 Jul 2026

Thanks @SniperSister for your PR, @tecpromotion for review, and @brianteeman and @ThomasFinnern for testing.

Add a Comment

Login with GitHub to post a comment