[#48166] - [5.4] fix installer disk error
- Pending
- Medium
- Build: 5.4-dev
- # 48166
- Diff
- Raheem54:update-fix-installer-disk-error
User tests: Successful: Unsuccessful:
Pull Request resolves #48156.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
update misleading installer error when disk space/quota exceeded by check free space before error
closes #48165
Testing Instructions
try to install any extension on system with full space and observe error message
Actual result BEFORE applying this Pull Request
displays: "install path does not exist"
Expected result AFTER applying this Pull Request
displays: "The filesystem is full or the user's disk quota has been exceeded."
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings Libraries |
do you mean to compare size source to free size in extension root in package adapter ?
what i mean is that your current code won't solve the reported problem.
| Labels |
Added:
Language Change
PR-5.4-dev
|
||
is edit this will solve it ?
is this edit will solve it ?
tecpromotion
- | Title |
|
||||||
I made all the changes and test failed I don't know why I'm just change the style
I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any confects I don't know why it failed
I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any conflicts I don't know why it failed
I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any confects I don't know why it failed
@Raheem54 Confects ... :-) I think you meant conflicts. System tests failed due to a timeout when testing extension installation from URL. That can happen sometimes. Not related to your PR. I've just restarted the failed CI jobs. Let's see if they pass this time.
@Raheem54 Confects ... :-) I think you meant conflicts. System tests failed due to a timeout when testing extension installation from URL. That can happen sometimes. Not related to your PR. I've just restarted the failed CI jobs. Let's see if they pass this time.
It failed again and I don't know how It was passing all tests before the update
QuyTon
-
this doesn't really solve the problem it just delays it. Perhaps a more sensible check would be against the size of the file being written to temp and also ensuring that there is enough space to extract it in the temp and then copy it to the correct location