User tests: Successful: Unsuccessful:
Pull Request resolves #48156.
update misleading installer error when disk space/quota exceeded by check free space before error
closes #48165
try to install any extension on system with full space and observe error message
displays: "install path does not exist"
displays: "The filesystem is full or the user's disk quota has been exceeded."
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Installation Language & Strings Libraries |
do you mean to compare size source to free size in extension root in package adapter ?
what i mean is that your current code won't solve the reported problem.
| Labels |
Added:
Language Change
PR-5.4-dev
|
||
is edit this will solve it ?
is this edit will solve it ?
| Title |
|
||||||
I made all the changes and test failed I don't know why I'm just change the style
I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any confects I don't know why it failed
I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any conflicts I don't know why it failed
I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any confects I don't know why it failed
@Raheem54 Confects ... :-) I think you meant conflicts. System tests failed due to a timeout when testing extension installation from URL. That can happen sometimes. Not related to your PR. I've just restarted the failed CI jobs. Let's see if they pass this time.
@Raheem54 Confects ... :-) I think you meant conflicts. System tests failed due to a timeout when testing extension installation from URL. That can happen sometimes. Not related to your PR. I've just restarted the failed CI jobs. Let's see if they pass this time.
It failed again and I don't know how It was passing all tests before the update
This pull request has been automatically rebased to 6.2-dev. Joomla! 5.4 is now in security only mode.
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
bug
PR-6.2-dev
Removed: PR-5.4-dev |
||
| Category | Installation Language & Strings Libraries | ⇒ | Libraries Administration Installation Language & Strings com_installer |
I don't think this approach is going to solve the underlying problem.
There are several issues with the current disk-space check.
Firstly, comparing the available disk space with the compressed archive size doesn't tell us whether there is sufficient space to extract the archive. A relatively small ZIP file can expand into a considerably larger directory.
Secondly, when installing an extension from a URL, the archive has already been downloaded into the temporary directory before unpack() is called. If the filesystem runs out of space during the download, this check is never reached.
More importantly, the new diskfull flag is only set when the preliminary check predicts insufficient space. If the extraction itself fails because the filesystem becomes full, the existing exception handler still returns the generic failure without setting that flag.
I think we should step back and look at the actual reason why the installer is displaying JLIB_INSTALLER_ABORT_DETECTMANIFEST when it cannot extract the package.
Rather than trying to predict disk-space requirements, I would prefer that we identify whether the extraction failed because files could not be written and report that appropriately.
The objective here is to give the user a meaningful error message, not necessarily to implement disk-space prediction throughout the installer.
I would suggest reconsidering this implementation before adding further complexity.
Okay thanks for your review, I'm now trying to fix this and I think the issue was that there is no validation for write the file in downloading process specially so now the write process has a validation but it's just write the reason in the log because I think the issue in the installModal.php here:
$p_file = InstallerHelper::downloadPackage($url);
// Was the package downloaded?
if (!$p_file) {
Factory::getApplication()->enqueueMessage(Text::_('COM_INSTALLER_MSG_INSTALL_INVALID_URL'), 'error');
return false;
}
that it just return the same message if the download function failed and there is many reasons for its fail so you can't specify the reason of fail and the same thing for upload, for disk validation on extracting the way of get message from exception and check it, I don't know It's enough or not put I think it would work.
this doesn't really solve the problem it just delays it. Perhaps a more sensible check would be against the size of the file being written to temp and also ensuring that there is enough space to extract it in the temp and then copy it to the correct location