Language Change bug PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Raheem54
Raheem54
30 Jul 2026

Pull Request resolves #48156.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

update misleading installer error when disk space/quota exceeded by check free space before error

closes #48165

Testing Instructions

try to install any extension on system with full space and observe error message

Actual result BEFORE applying this Pull Request

displays: "install path does not exist"

Expected result AFTER applying this Pull Request

displays: "The filesystem is full or the user's disk quota has been exceeded."

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Raheem54 Raheem54 - open - 30 Jul 2026
avatar Raheem54 Raheem54 - change - 30 Jul 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2026
Category ⇒ Installation Language & Strings Libraries
avatar brianteeman
brianteeman - comment - 30 Jul 2026

this doesn't really solve the problem it just delays it. Perhaps a more sensible check would be against the size of the file being written to temp and also ensuring that there is enough space to extract it in the temp and then copy it to the correct location

avatar Raheem54
Raheem54 - comment - 30 Jul 2026

do you mean to compare size source to free size in extension root in package adapter ?

avatar brianteeman
brianteeman - comment - 30 Jul 2026

what i mean is that your current code won't solve the reported problem.

avatar Raheem54 Raheem54 - change - 30 Jul 2026
Labels Added: Language Change PR-5.4-dev
avatar Raheem54
Raheem54 - comment - 30 Jul 2026

is edit this will solve it ?

avatar Raheem54
Raheem54 - comment - 30 Jul 2026

is this edit will solve it ?

avatar Raheem54 Raheem54 - change - 30 Jul 2026
The description was changed
avatar Raheem54 Raheem54 - edited - 30 Jul 2026
avatar Raheem54 Raheem54 - change - 30 Jul 2026
The description was changed
avatar Raheem54 Raheem54 - edited - 30 Jul 2026
avatar tecpromotion tecpromotion - change - 8 Aug 2026
Title
…
fix installer disk error
[5.4] fix installer disk error
avatar tecpromotion tecpromotion - edited - 8 Aug 2026
avatar Raheem54
Raheem54 - comment - 12 Aug 2026

I made all the changes and test failed I don't know why I'm just change the style

avatar Raheem54
Raheem54 - comment - 12 Aug 2026

I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any confects I don't know why it failed

avatar Raheem54
Raheem54 - comment - 12 Aug 2026

I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any conflicts I don't know why it failed

avatar richard67
richard67 - comment - 12 Aug 2026

I made all the changes and test failed I don't know why I'm just change the style, I think it's related to update the branch but there is no any confects I don't know why it failed

@Raheem54 Confects ... :-) I think you meant conflicts. System tests failed due to a timeout when testing extension installation from URL. That can happen sometimes. Not related to your PR. I've just restarted the failed CI jobs. Let's see if they pass this time.

avatar Raheem54
Raheem54 - comment - 12 Aug 2026

@Raheem54 Confects ... :-) I think you meant conflicts. System tests failed due to a timeout when testing extension installation from URL. That can happen sometimes. Not related to your PR. I've just restarted the failed CI jobs. Let's see if they pass this time.

It failed again and I don't know how It was passing all tests before the update

avatar QuyTon QuyTon - change - 13 Aug 2026
The description was changed
avatar QuyTon QuyTon - edited - 13 Aug 2026
avatar richard67
richard67 - comment - 15 Aug 2026

@Raheem54 There is no need to always update your branch for this PR when the base branch 5.4-dev changed, as long as no conflicts are shown on GitHub for this PR here.

avatar HLeithner
HLeithner - comment - 5 Nov 2026

This pull request has been automatically rebased to 6.2-dev. Joomla! 5.4 is now in security only mode.

avatar Raheem54 Raheem54 - change - 6 Nov 2026
Title
…
[5.4] fix installer disk error
[5.2] fix installer disk error
avatar Raheem54 Raheem54 - edited - 6 Nov 2026
avatar richard67 richard67 - change - 6 Nov 2026
Title
…
[5.2] fix installer disk error
[6.2] fix installer disk error
avatar richard67 richard67 - edited - 6 Nov 2026
avatar Raheem54 Raheem54 - change - 11 Nov 2026
Labels Added: bug PR-6.2-dev
Removed: PR-5.4-dev
avatar joomla-bot joomla-bot - change - 11 Nov 2026
Category Installation Language & Strings Libraries ⇒ Libraries Administration Installation Language & Strings com_installer
avatar brianteeman
brianteeman - comment - 11 Nov 2026

I don't think this approach is going to solve the underlying problem.

There are several issues with the current disk-space check.

Firstly, comparing the available disk space with the compressed archive size doesn't tell us whether there is sufficient space to extract the archive. A relatively small ZIP file can expand into a considerably larger directory.

Secondly, when installing an extension from a URL, the archive has already been downloaded into the temporary directory before unpack() is called. If the filesystem runs out of space during the download, this check is never reached.

More importantly, the new diskfull flag is only set when the preliminary check predicts insufficient space. If the extraction itself fails because the filesystem becomes full, the existing exception handler still returns the generic failure without setting that flag.

I think we should step back and look at the actual reason why the installer is displaying JLIB_INSTALLER_ABORT_DETECTMANIFEST when it cannot extract the package.

Rather than trying to predict disk-space requirements, I would prefer that we identify whether the extraction failed because files could not be written and report that appropriately.

The objective here is to give the user a meaningful error message, not necessarily to implement disk-space prediction throughout the installer.

I would suggest reconsidering this implementation before adding further complexity.

avatar Raheem54
Raheem54 - comment - 12 Nov 2026

Okay thanks for your review, I'm now trying to fix this and I think the issue was that there is no validation for write the file in downloading process specially so now the write process has a validation but it's just write the reason in the log because I think the issue in the installModal.php here:

$p_file = InstallerHelper::downloadPackage($url);

// Was the package downloaded?
if (!$p_file) {
      Factory::getApplication()->enqueueMessage(Text::_('COM_INSTALLER_MSG_INSTALL_INVALID_URL'), 'error');

      return false;
 }

that it just return the same message if the download function failed and there is many reasons for its fail so you can't specify the reason of fail and the same thing for upload, for disk validation on extracting the way of get message from exception and check it, I don't know It's enough or not put I think it would work.

Add a Comment

Login with GitHub to post a comment