[#48162] - [6.2] Remove all print button related code remnants
- Pending
- Medium
- Build: 6.2-dev
- # 48162
- Diff
- brianteeman:print
User tests: Successful: Unsuccessful:
Pull Request resolves #47979 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
From what I can tell this code is a remnant from when we had a print button but this was removed with #24025
Testing Instructions
I think this can only be tested by code review as from my perspective none of this code that is removed here is actually used
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content com_newsfeeds Plugins |
| Labels |
Added:
PR-6.2-dev
|
||
thats why i asked first #47979 (comment) but as it got no reply the only option seemed to be to create the pr and watch it die in flames
thats why i asked first #47979 (comment) but as it got no reply the only option seemed to be to create the pr and watch it die in flames have it reviewed
The changes in the view class can break template overrides when they use $this->print. For safety, I would rebase it to 7.0-dev.
If we want to be correct and follow our process, then they have to deprecated and then removed in 8.0.