? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Oct 2014

Also fixes bug where images can't be viewed in tags.

N.B. The version note field is untouched (even though it shows in the diff - my ide really didn't like this file for some reason and was intent on autoformatting it!!)

Executive summary

You can't save tags in postgres because of an SQL error. For a related reason in all database formats the images attached to a tag could not be viewed in the frontend

Detailed description

In the code sprint the images fieldset was moved inside the params <field> attribute. This meant the name of the images fields changed from jform[images][image_intro] to jform[params][image_intro]. This meant all images got stored in the params column in the database column leaving the images column blank. As a result no images showed in the frontend on all databases and additionally in postgres the

Backwards Compatibility

Any images created on a tag since 3.2 will now not show and will be wiped on next saving the tag (as they are stored in the params column and not the images column as they are supposed to). However offsetting this any images stored between tags introduction in 3.1 and 3.2 WILL now show.

Testing Instructions

Test saving a tag in postgres on version 3.3.6 (note NOT current staging because of a regression that was introduced by #4114)

You can test this on mysql by checking that images now function in the frontend correctly (note in postgres looks like more sql errors mean you can't open a tag yet - that is for a future PR)

Is Brian Happy yet

You'll have to ask @brianteeman whether this is detailed enough :P

avatar wilsonge wilsonge - open - 18 Oct 2014
avatar jissues-bot jissues-bot - change - 18 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 18 Oct 2014
Category Postgresql Tags
avatar brianteeman
brianteeman - comment - 18 Oct 2014

Is Brian Happy yet

You'll have to ask @brianteeman whether this is detailed enough :P

Too Right I am!!!!

This is awesome - this is what testers need. When people complain that their code doesnt get tested it is usally because they dont explain anything. Code with detailed instructions gets tested faster and committed faster

Thanks You

avatar brianteeman brianteeman - test_item - 18 Oct 2014 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Oct 2014

Thanks to the detailed write up I have been able to test the fix and confirm it works

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4815.

avatar alikon
alikon - comment - 18 Oct 2014

@test success

something similar related to the #4687, #3087 ?

avatar brianteeman brianteeman - change - 18 Oct 2014
Status Pending Ready to Commit
avatar brianteeman brianteeman - alter_testresult - 18 Oct 2014 - alikon: Tested successfully
avatar brianteeman
brianteeman - comment - 18 Oct 2014

Look at that George. Have you ever had a PR of yours move to RTC so fast.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4815.

avatar brianteeman
brianteeman - comment - 18 Oct 2014

@alikon yes it could well be - nulls are the big diff between the sql flavours

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4815.

avatar sovainfo
sovainfo - comment - 18 Oct 2014

@test OK, after removing NOT NULL from #__tags:images
Issue reproduced on PG, applied changes of PR manually in addition to removing NOT NULL as mentioned above. PR solves issue!

avatar ketchupmonki
ketchupmonki - comment - 19 Oct 2014

Successfully tested saving tag on staging with postgres.
Also successfully tested with images on mysql.

avatar ketchupmonki ketchupmonki - test_item - 19 Oct 2014 - Tested successfully
avatar Bakual Bakual - close - 19 Oct 2014
avatar Bakual Bakual - change - 19 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-19 18:40:23
avatar Bakual
Bakual - comment - 19 Oct 2014

Merged into staging. Thanks!

Add a Comment

Login with GitHub to post a comment