User tests: Successful: Unsuccessful:
For now, it is not possible to set Min date and Max date for Calendar control so as to define range of dates.
minDate="16-10-2014" AND maxDate="16-10-2015"
Both Attributes are missing.
See #4801
For testing:
add dateStart and/or dateEnd eq. dateStart="16-10-2014" dateEnd="17-10-2015" as calendar field params.
Labels |
Added:
?
|
Title |
|
||||||
Rel_Number | ⇒ | 4801 | |||||
Relation Type | ⇒ | Related to |
Title |
|
Category | ⇒ | Libraries |
Updated on git but it pulled old comment. Add dateStart="16-10-2014" dateEnd="17-10-2015" attributes for calendar field.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
Add new attributes to field in file: administrator\components\com_content\models\forms\article.xml
See /administrator/index.php?option=com_content&view=article&layout=edit for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
Patch is not working properly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
Patch is not working for me also. It breaking my site.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
If the patch fails on pach tester, please check manual file difference update before adding unsuccessful test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
@kirapwn can you make Travis happy?
FILE: ...ravis/build/joomla/joomla-cms/libraries/joomla/form/fields/calendar.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
163 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: /home/travis/build/joomla/joomla-cms/libraries/cms/html/html.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
1026 | ERROR | Concat operator must be followed by one space
1026 | ERROR | Concat operator must be preceeded by one space
--------------------------------------------------------------------------------
See: https://travis-ci.org/joomla/joomla-cms/jobs/38312265
Patch is not working for me also. It breaking my site.
Please explain how it break your site and explain what don't work as you expect. So @kirapwn can have a look into it. Thanks.
I have just applied patch on my latest Joomla site & after that whole site was broken
It was saying
Both front end & backend not working
400: Invalid request
I tried to figured out the issue by setting error reporting to maximum
Fatal error: Class 'JHtml' not found on the files
eg .
JHtml::_('behavior.modal');
Class 'JHtml' not found
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
One more thing after applying patch
following files replaced by
400: invalid request
I fixed formating so travis should be ok now. But I don't see how this could cause JHtml class not found error
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
If you have files replaced with 400: invalid request. Please copy files from github (or just the line changed) and test it without using patchtester as it fails to update files sometimes.
See: https://github.com/joomla/joomla-cms/pull/4814/files
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
@test: It works almost correctly. The test steps tells us to use the date format of dd-mm-yyyy but this breaks the Today button on the calendar. The default date that is shown when creating a new banner is 2001-01-01, so then I click on the calendar and want to go to today and click on the Today button nothing happens.
When I change the default dates in my XML file to the format of mm-dd-yyyy, the Today button works as expected.
Now the question is how the dates should be entered in the XML definition. mm-dd-yyyy is not inline with how the calendar shows the date. The date shown is yyyy-mm-dd in the input field, so I think the XML should use this format.
Patch applies fine manually, there is just 1 Travis issue with a whitespace issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4814.
Please fix the codestyle issue that travis reports.
I submitted a PR to your repo to fix the codestyle change. If you apply it then it should pass travis (the codechecker)
Hello @kirapwn
Thank you for your contribution.
Can you please follow up on the unsuccessful test results?
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
Status | Pending | ⇒ | Information Required |
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-12 13:03:24 |
Closed_By | ⇒ | brianteeman |
Has this ever been added?
For testing:
add dateStart and/or dateEnd eq. dateStart="16-10-2014" dateEnd="17-10-2015" as calendar field params.