[#48091] - [5.4][plg_actionlog] log user block/unblock only 1
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 48091
- Diff
- alikon:patch-4
User tests: Successful: Unsuccessful:
Pull Request resolves #48089.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
log 1 time
Testing Instructions
Steps to reproduce:
Go to Users: Manage.
Select a user, click Block (or Unblock)
Go to Users: Actions Log.
Actual result BEFORE applying this Pull Request
2 entries
Expected result AFTER applying this Pull Request
1 entry
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-5.4-dev
|
||
@shinderohanoffical should be fixed now
@alikon Tested — the original duplicate block/unblock entries are gone now, and the earlier regression on plain "user updated" logging is also fixed. 👍
One more thing I noticed going through the diff: in onUserAfterSave(), addLog() is now only reached via the $task === 'block'/'unblock' branch (which returns early) or the $action === 'update' branch. That means $action === 'add' (creating a new user) and $action === 'register' (self-registration) never reach an addLog() call anymore — before this PR, those were covered by the generic unconditional addLog() call that got moved/scoped down in an earlier commit.
Can you confirm whether adding a new user or registering still shows up in the Action Log on your end? On my test it doesn't seem to be logged anymore.
i'll check more carefully this time 😇
| Category | Front End Plugins | ⇒ | Front End Plugins JavaScript Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
@shinderohanoffical
i've added some system tests to cover some scenarios
@alikon Looks good now — I traced through the updated logic and the final addLog() call at the end of the method covers add/register/update correctly (outside the if blocks now), while the toolbar block/unblock path still only logs once via the early return. Nice touch adding the Cypress tests for all four scenarios too.
thanks!
I have tested this item ✅ successfully on fee4c25
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48091.
I have tested this item ✅ successfully on fee4c25
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48091.
I have tested this item ✅ successfully on fee4c25
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48091.
I have tested this item ✅ successfully on fee4c25
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48091.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48091.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48091.
| Labels |
Added:
RTC
bug
|
||
thanks i'll check it later