This doesnt ADD dynamic author filtering it Replaces author filtering with dynamic author filtering

Either that is a bug in this PR or its a breaking change which causes the loss of useful functionality

Before this PR

With this PR

I have tested this item 🔴 unsuccessfully on 6509a9f

I have tested this item 🔴 unsuccessfully on 6509a9f

If you swich Active user only to "no" you can select the users?
But I agree that the switch should be "no" as default.

I have tested this item 🔴 unsuccessfully on 6509a9f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48086.

Thanks Brian, the intention is to add dynamic author filtering, not replace the existing static author filtering. (I forgot and use the old PR template )
when Active User Only is disabled, the existing author checkbox list remains visible and works exactly as before. The dynamic behaviour will only apply when the new option is enabled.

I have tested this item 🔴 unsuccessfully on 6509a9f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48086.

Thanks Brian, the intention is to add dynamic author filtering, not replace the existing static author filtering. (I forgot and use the old PR description, but I updated it)
when Active User Only is disabled, the existing author checkbox list remains visible and works exactly as before. The dynamic behaviour will only apply when the new option is enabled.

Then theactive user only must default to disabled

The filter shows the same selection as usual but adds a button.

The filter shows the same selection as usual but adds a button. It is disabled by default

Then theactive user only must default to disabled

the default option is "no"

weird - just rechecked and it is disabled - no idea why i thought it was not

I have tested this item ✅ successfully on 6509a9f

I have tested this item ✅ successfully on 6509a9f

I have tested this item ✅ successfully on 6509a9f

I have tested this item ✅ successfully on 6509a9f

RTC

RTC

I have tested this item 🔴 unsuccessfully on b9235ab

For the active user: Works only if the author alias is identical to the users name.

I have tested this item 🔴 unsuccessfully on b9235ab

For the active user: Works only if the author alias is identical to the users name.

For the active user: Works only if the author alias is identical to the users name.

Thank you for testing, but I don't understand. Could you give an example?

For the active user: Works only if the author alias is identical to the users name.

Thank you for testing, but I don't understand. Could you give an example?

With the sample data installed - the articles go with Author Alias 'Joomla' and they are not found when i'm logged in as Administrator

For the active user: Works only if the author alias is identical to the users name.

Thank you for testing, but I don't understand. Could you give an example?

With the sample data installed - the articles go with Author Alias 'Joomla' and they are not found when i'm logged in as Administrator

Create two users:
User A: name Alice Smith, username alice
User B: name Bob Jones, username bob

Create two articles:
Article 1: created by User A, with Created by Alias set to Alice Editorial
Article 2: created by User B, with Created by Alias set to Bob Editorial
The alias must be different from the user name.

is not this the intended behaviour?

For the active user: Works only if the author alias is identical to the users name.

Thank you for testing, but I don't understand. Could you give an example?

With the sample data installed - the articles go with Author Alias 'Joomla' and they are not found when i'm logged in as Administrator

Create two users:
User A: name Alice Smith, username alice
User B: name Bob Jones, username bob

Create two articles:
Article 1: created by User A, with Created by Alias set to "Alice article"
Article 2: created by User B, with Created by Alias set to "Bob article"
The alias must be different from the user name.

is not this the intended behaviour?

For the active user: Works only if the author alias is identical to the users name.

Thank you for testing, but I don't understand. Could you give an example?

With the sample data installed - the articles go with Author Alias 'Joomla' and they are not found when i'm logged in as Administrator

Create two users:
name Alice Smith, username alice
name Bob Jones, username bob

Create two articles:
Article 1: created by alice, with Created by Alias set to "Alice article"
Article 2: created by bob, with Created by Alias set to "Bob article"
The alias must be different from the user name.

is not this the intended behaviour?

I have tested this item 🔴 unsuccessfully on b9235abFor the active user: Works only if the author alias is identical to the users name.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48086.

I fixed the issue by check: if Created by Alias is filled: use that alias, otherwise: use the logged-in user’s name

just retested and i get this error whenever i open an existing article

0 Joomla\Component\Content\Administrator\Service\PreviewTokenService::__construct(): Argument #1 ($secret) must be of type string, null given, called in C:\repos\j62\administrator\components\com_content\src\View\Article\HtmlView.php on line 97

 | Function | Location
-- | -- | --
1 | () | JROOT\administrator\components\com_content\src\Service\PreviewTokenService.php:45
2 | Joomla\Component\Content\Administrator\Service\PreviewTokenService->__construct() | JROOT\administrator\components\com_content\src\View\Article\HtmlView.php:97
3 | Joomla\Component\Content\Administrator\View\Article\HtmlView->initializeView() | JROOT\libraries\src\MVC\View\FormView.php:179
4 | Joomla\CMS\MVC\View\FormView->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:705
5 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT\administrator\components\com_content\src\Controller\DisplayController.php:70
6 | Joomla\Component\Content\Administrator\Controller\DisplayController->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:738
7 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:143
8 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:361
9 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\AdministratorApplication.php:150
10 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT\libraries\src\Application\AdministratorApplication.php:206
11 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:320
12 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\administrator\includes\app.php:58
13 | require_once() | JROOT\administrator\index.php:32

deleted

I have tested this item 🔴 unsuccessfully on 89ae0d5

I have tested this item 🔴 unsuccessfully on 89ae0d5

just retested and i get this error whenever i open an existing article

0 Joomla\Component\Content\Administrator\Service\PreviewTokenService::__construct(): Argument #1 ($secret) must be of type string, null given, called in C:\repos\j62\administrator\components\com_content\src\View\Article\HtmlView.php on line 97

 | Function | Location
-- | -- | --
1 | () | JROOT\administrator\components\com_content\src\Service\PreviewTokenService.php:45
2 | Joomla\Component\Content\Administrator\Service\PreviewTokenService->__construct() | JROOT\administrator\components\com_content\src\View\Article\HtmlView.php:97
3 | Joomla\Component\Content\Administrator\View\Article\HtmlView->initializeView() | JROOT\libraries\src\MVC\View\FormView.php:179
4 | Joomla\CMS\MVC\View\FormView->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:705
5 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT\administrator\components\com_content\src\Controller\DisplayController.php:70
6 | Joomla\Component\Content\Administrator\Controller\DisplayController->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:738
7 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:143
8 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:361
9 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\AdministratorApplication.php:150
10 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT\libraries\src\Application\AdministratorApplication.php:206
11 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:320
12 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\administrator\includes\app.php:58
13 | require_once() | JROOT\administrator\index.php:32

it works here without any errors

retested - same problem - sorry

@Reda-Muhamed You might have to set PHP Error Reporting to Maximum in global configuration.

@Reda-Muhamed You might have to set PHP Error Reporting to Maximum in global configuration.

I did it and still able to open any article

Hi @brianteeman, this error you have is probably due to this PR #48030.
Because it's just merged and it's the only PreviewTokenService in Joomla.

yes - looks like a problem with that PR

yes - looks like a problem with that PR

or a problem with me

What is the expected behaviour in this scenario. There is just one user on the site but there are two authors - one is the user (brian) the other is an alias (joomla).

If I create an author filter by either brian or joomla then i only get the content created by that author

If I create a filter (active user) then I get the results from both authors - which seems correct to me as the active user is the author and alias.

If I create a filter (active user) then I get the results from both authors - which seems correct to me as the active user is the author and alias

This was intended.

thanks for confirming

I have tested this item ✅ successfully on 89ae0d5

I have tested this item ✅ successfully on 89ae0d5

What is the expected behaviour in this scenario. There is just one user on the site but there are two authors - one is the user (brian) the other is an alias (joomla).

If I create an author filter by either brian or joomla then i only get the content created by that author

If I create a filter (active user) then I get the results from both authors - which seems correct to me as the active user is the author and alias.

Now we consider active user is the author and alias after Martin test