RTC Documentation Required NPM Resource Changed PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
11 Jul 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This pr fixes a workflow issue where clicking the SearchTools clear button clears the required workflow context (extension) along with the other filters. As a result, the request is submitted with an empty extension value, causing the workflows page to fail with an extension not set exception.

Testing Instructions

  1. Go to content > workflows.
  2. Apply a filter (eg unpublished)
  3. Clear the filter

Actual result BEFORE applying this Pull Request

An error with extension not found appears.

Expected result AFTER applying this Pull Request

No error and clear works correctly.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 11 Jul 2026
avatar adarshdubey03 adarshdubey03 - change - 11 Jul 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2026
Category ⇒ Administration com_workflow JavaScript Repository NPM Change
avatar brianteeman
brianteeman - comment - 13 Jul 2026

I am unable to replicate the reported bug

avatar adarshdubey03
adarshdubey03 - comment - 13 Jul 2026

@brianteeman

Recording.2026-07-13.204351.mp4
avatar brianteeman
brianteeman - comment - 13 Jul 2026

@adarshdubey03 thanks I was looking in the wrong place

avatar brianteeman brianteeman - test_item - 13 Jul 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Jul 2026

I have tested this item ✅ successfully on 02779d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar brianteeman
brianteeman - comment - 13 Jul 2026

I have tested this item ✅ successfully on 02779d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar LadySolveig LadySolveig - test_item - 13 Jul 2026 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 13 Jul 2026

I have tested this item ✅ successfully on 02779d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar LadySolveig
LadySolveig - comment - 13 Jul 2026

I have tested this item ✅ successfully on 02779d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar QuyTon QuyTon - change - 13 Jul 2026
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed PR-6.1-dev
avatar QuyTon
QuyTon - comment - 13 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar QuyTon
QuyTon - comment - 13 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar HLeithner
HLeithner - comment - 17 Jul 2026

Hi,

thanks for your PR.

I have one suggestion, it would be better to have this a bit more flexible, instead of a true/false parameter, add an array of fieldnames which should not be reset on clear.

avatar adarshdubey03
adarshdubey03 - comment - 19 Jul 2026

@HLeithner Done :)

avatar QuyTon QuyTon - change - 19 Jul 2026
Status Ready to Commit ⇒ Pending
avatar QuyTon
QuyTon - comment - 19 Jul 2026

Please retest with the requested change. Thanks.

avatar LadySolveig
LadySolveig - comment - 7 Aug 2026

@adarshdubey03 an update to your testing instructions after your last changes would be nice that would reflect at least two different test cases. Thank you!

avatar LadySolveig
LadySolveig - comment - 7 Aug 2026

Test Case 2:
Change line 84 in administrator/components/com_content/tmpl/articles/default.php to

echo LayoutHelper::render('joomla.searchtools.default', ['view' => $this, 'options' => ['selectorFieldName' => 'featured', 'fieldsToPreserveOnClear' => ['filter[published]', 'filter[access][]']]]);
image

Set the two filters that should be preserved in articles list view and also a few others.
image

✅ Filter Access and Filter Publish are preserved, all other filters have been reset.

avatar LadySolveig LadySolveig - test_item - 7 Aug 2026 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 7 Aug 2026

I have tested this item ✅ successfully on b2eb452

I think this should be documented. I’m not sure whether it would be sufficient in the migration notes, but I haven’t found a suitable section in the manual at short notice either.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar LadySolveig
LadySolveig - comment - 7 Aug 2026

I have tested this item ✅ successfully on b2eb452

I think this should be documented. I’m not sure whether it would be sufficient in the migration notes, but I haven’t found a suitable section in the manual at short notice either.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar LadySolveig
LadySolveig - comment - 7 Aug 2026

I have tested this item ✅ successfully on b2eb452

I think this should be documented. I’m not sure whether it would be sufficient in the migration notes, but I haven’t found a suitable section in the manual at short notice either. Any idea @HLeithner


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar brianteeman brianteeman - test_item - 26 Aug 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Aug 2026

I have tested this item ✅ successfully on b2eb452


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar brianteeman
brianteeman - comment - 26 Aug 2026

I have tested this item ✅ successfully on b2eb452


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar richard67 richard67 - change - 26 Aug 2026
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 26 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar richard67
richard67 - comment - 26 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.

avatar richard67
richard67 - comment - 26 Aug 2026

Setting RTC (ready to commit) as the PR has 2 successful human tests and seems ok to me by review.

However, I'm not sure if 6.1-dev is the right target branch.

@HLeithner @tecpromotion What do you think?

avatar tecpromotion tecpromotion - change - 12 Sep 2026
Labels Added: RTC Documentation Required
avatar tecpromotion
tecpromotion - comment - 12 Sep 2026

However, I'm not sure if 6.1-dev is the right target branch.

The behaviour this PR fixes was introduced by #47352 "[5.4] Reset selector filters when clearing
SearchTools filters"
(d2bce5b6dc, 2026-03-11) — the commit that added
.js-stools-container-selector to the clear condition. That commit is in 5.4-dev and shipped in
Joomla 5.4.4, so this is a live regression in released 5.4, not a 6.1-only issue.

I reproduced it on a stock 5.4.9-dev instance: Content → Workflows → set Status filter → Clear →
500 "Extension not set." Identical to 6.1.

So 5.4-dev is the natural target. The one argument for 6.1 is that the PR adds a new public
option
(fieldsToPreserveOnClear) to the searchtools layout/JS, and new API in a patch release is
unusual. If that is the blocker, the two clean ways forward are:

  • merge as-is into 5.4-dev — the option is additive and defaults to [], so it is fully b/c; or
  • fix 5.4 minimally (revert the selector part of #47352) and land the opt-in option in 6.1.

Either way, 5.4 should not keep shipping a 500 on a button click. @richard67 — that is my answer to
your branch question.

avatar richard67
richard67 - comment - 12 Sep 2026

The one argument for 6.1 is that the PR adds a new public
option (fieldsToPreserveOnClear) to the searchtools layout/JS, and new API in a patch release is
unusual.

It will be a patch release in 6.1-dev as well as in 5.4-dev. Only in 6.2-dev or 6.3-dev or 7.0-dev it would not be a patch release yet.

avatar richard67
richard67 - comment - 12 Sep 2026

The one argument for 6.1 is that the PR adds a new public
option (fieldsToPreserveOnClear) to the searchtools layout/JS, and new API in a patch release is
unusual.

@tecpromotion It will be a patch release in 6.1-dev as well as in 5.4-dev. Only in 6.2-dev or 6.3-dev or 7.0-dev it would not be a patch release yet.

avatar richard67 richard67 - close - 16 Sep 2026
avatar richard67
richard67 - comment - 16 Sep 2026

I've tried to rebase this PR to 5.4-dev, but that did not work well. It seems to be in general not easy to rebase from an upper to the lower branch.

So I have created PR #48468 for 5.4-dev, which is equal to this one here and keeps the commit history, so @adarshdubey03 will be mentioned as co-author in the commit when that other PR gets merged (and release managers do it right).

Thanks a lot @adarshdubey03 for your work, @QuyTon and @HLeithner for reviews, and @LadySolveig and @brianteeman for testing.

As the differences in the modified files between 5.4-dev and 6.1-dev have no impact on the changes made by this PR, the successful human tests for this PR can still be considered as valid.

Closing in favour of #48468.

avatar richard67 richard67 - change - 16 Sep 2026
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-09-16 17:40:05
Closed_By ⇒ richard67

Add a Comment

Login with GitHub to post a comment