[#48079] - [6.1] fix clearing the workflows context selector
- Ready to Commit
- Medium
- Build: 6.1-dev
- # 48079
- Diff
- adarshdubey03:fix/workflows-preserve-selector-clear-6.1
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This pr fixes a workflow issue where clicking the SearchTools clear button clears the required workflow context (extension) along with the other filters. As a result, the request is submitted with an empty extension value, causing the workflows page to fail with an extension not set exception.
Testing Instructions
- Go to content > workflows.
- Apply a filter (eg unpublished)
- Clear the filter
Actual result BEFORE applying this Pull Request
An error with extension not found appears.
Expected result AFTER applying this Pull Request
No error and clear works correctly.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow JavaScript Repository NPM Change |
Recording.2026-07-13.204351.mp4
@adarshdubey03 thanks I was looking in the wrong place
I have tested this item ✅ successfully on 02779d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on 02779d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on 02779d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on 02779d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-6.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
Hi,
thanks for your PR.
I have one suggestion, it would be better to have this a bit more flexible, instead of a true/false parameter, add an array of fieldnames which should not be reset on clear.
@HLeithner Done :)
| Status | Ready to Commit | ⇒ | Pending |
Please retest with the requested change. Thanks.
@adarshdubey03 an update to your testing instructions after your last changes would be nice that would reflect at least two different test cases. Thank you!
Test Case 2:
Change line 84 in administrator/components/com_content/tmpl/articles/default.php to
echo LayoutHelper::render('joomla.searchtools.default', ['view' => $this, 'options' => ['selectorFieldName' => 'featured', 'fieldsToPreserveOnClear' => ['filter[published]', 'filter[access][]']]]);
Set the two filters that should be preserved in articles list view and also a few others.
✅ Filter Access and Filter Publish are preserved, all other filters have been reset.
I have tested this item ✅ successfully on b2eb452
I think this should be documented. I’m not sure whether it would be sufficient in the migration notes, but I haven’t found a suitable section in the manual at short notice either.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on b2eb452
I think this should be documented. I’m not sure whether it would be sufficient in the migration notes, but I haven’t found a suitable section in the manual at short notice either.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on b2eb452
I think this should be documented. I’m not sure whether it would be sufficient in the migration notes, but I haven’t found a suitable section in the manual at short notice either. Any idea @HLeithner
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on b2eb452
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
I have tested this item ✅ successfully on b2eb452
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48079.
Setting RTC (ready to commit) as the PR has 2 successful human tests and seems ok to me by review.
However, I'm not sure if 6.1-dev is the right target branch.
@HLeithner @tecpromotion What do you think?
I am unable to replicate the reported bug