RTC PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
14 Jun 2026

Pull Request resolves #45891, #47199 and #46877 (comment).

Same as #47272 and #47273 but for 6.2 as new dev dependencies

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

  • add @stylistic/eslint-plugin to get basic code style checks for javascript files back
  • add eslint-plugin-cypress to check files for system tests (cypress) and fix #47199
  • update eslint config to use eslint-plugin-vue
  • reapply #44852 to exit on warnings
  • fix existing code style errors

Testing Instructions

run npm run lint:js and npm run lint:testjs

Actual result BEFORE applying this Pull Request

basic code style (indentation, comma, semicolon) is not checked
vue files are not checked

Expected result AFTER applying this Pull Request

basic code style (indentation, comma, semicolon) is checked (again)
vue files are checked
warnings results in exit code 1

Link to documentations

Please select:

  • No documentation changes for guide.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 14 Jun 2026
avatar heelc29 heelc29 - change - 14 Jun 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2026
Category JavaScript Repository
avatar github-actions[bot]
github-actions[bot] - comment - 22 Jun 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar heelc29 heelc29 - change - 24 Jun 2026
Labels Added: Conflicting Files PR-6.2-dev
avatar github-actions[bot]
github-actions[bot] - comment - 26 Jun 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar muhme muhme - test_item - 3 Jul 2026 - Tested successfully
avatar muhme
muhme - comment - 3 Jul 2026

I have tested this item ✅ successfully on 00a8b5f

Tested with JBT

  • Before PR all three style hacks (indent, comma, semicolon) are not reported on:
    • one JS file in media/
    • one JS file in tests/
  • Applied PR with Patch Tester and npm ci
  • After PR the modifications are shown for files with lint:js and lint:testjs
avatar muhme
muhme - comment - 3 Jul 2026

I have tested this item ✅ successfully on 00a8b5f

Tested with JBT

  • Before PR all three style hacks (indent, comma, semicolon) are not reported on:
    • one JS file in media/
    • one JS file in tests/
  • Applied PR with Patch Tester and npm ci
  • After PR the modifications are shown for files with lint:js and lint:testjs
avatar ThomasFinnern ThomasFinnern - test_item - 3 Jul 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 3 Jul 2026

I have tested this item ✅ successfully on 00a8b5f

Tested

  • change of ',' in a function call
  • double ';;' at the end of a line
  • changed indention of lines

on files:

avatar ThomasFinnern
ThomasFinnern - comment - 3 Jul 2026

I have tested this item ✅ successfully on 00a8b5f

Tested

  • change of ',' in a function call
  • double ';;' at the end of a line
  • changed indention of lines

on files:

avatar QuyTon QuyTon - change - 3 Jul 2026
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 3 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47962.

avatar QuyTon
QuyTon - comment - 3 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47962.

avatar MacJoom MacJoom - change - 6 Jul 2026
Labels Added: RTC
Removed: Conflicting Files
avatar MacJoom
MacJoom - comment - 6 Jul 2026

@heelc29 - Thanks for the PR - we have some code style fails.

avatar heelc29
heelc29 - comment - 6 Jul 2026

@heelc29 - Thanks for the PR - we have some code style fails.

@MacJoom solved. They are from branch update (upmerge):

avatar MacJoom MacJoom - change - 6 Jul 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-07-06 15:18:35
Closed_By MacJoom
avatar MacJoom MacJoom - close - 6 Jul 2026
avatar MacJoom MacJoom - merge - 6 Jul 2026
avatar MacJoom
MacJoom - comment - 6 Jul 2026

Thank you!

Add a Comment

Login with GitHub to post a comment