RTC Language Change NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar MacJoom
MacJoom
7 Jun 2026

Testing deprecations yesterday i discovered that the Indexer Debugger was broken since 5.4 or earlier

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Generated partly by AI

Summary of Changes

Fixes the Finder debug adapter constructor so debug indexing can boot finder plugins using the same constructor
signature as the regular adapter.

Testing Instructions

  1. Turn on debugging in Global Configuration.
  2. Go to Smart Search in the administrator.
  3. Click the Index Debugging button (Dropdown under Index - only visible if global debugging is turned on)
  4. Select a finder plugin and enter an item ID.
  5. Test entering no ID or not exisisting ID
  6. Click the index button - you will get an error in output with the message that the item was not indexed.
  7. Test an existing ID - you will see the result of the index done by the plugin

Actual result BEFORE applying this Pull Request

The debug request fails with a constructor type error when booting the selected finder plugin.

Expected result AFTER applying this Pull Request

The selected finder plugin is booted and the debug indexing output is shown.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar MacJoom MacJoom - open - 7 Jun 2026
avatar MacJoom MacJoom - change - 7 Jun 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2026
Category Administration com_finder Language & Strings
avatar MacJoom MacJoom - change - 7 Jun 2026
Labels Added: Language Change PR-5.4-dev
avatar brianteeman
brianteeman - comment - 7 Jun 2026

Is this the expected output AFTER applying the PR

{"buffer":"","memory":18874368,"error":true,"header":"An Error Has Occurred","message":"No item was indexed. Check that the selected plugin supports the entered ID.","batchSize":null,"batchOffset":null,"totalItems":null,"pluginState":null,"startTime":null,"endTime":null,"start":null,"complete":null}

avatar brianteeman
brianteeman - comment - 7 Jun 2026

Is this JSON the expected output AFTER applying the PR

{"buffer":"","memory":18874368,"error":true,"header":"An Error Has Occurred","message":"No item was indexed. Check that the selected plugin supports the entered ID.","batchSize":null,"batchOffset":null,"totalItems":null,"pluginState":null,"startTime":null,"endTime":null,"start":null,"complete":null}

avatar MacJoom
MacJoom - comment - 7 Jun 2026

Yes that's the expected behavior. Thanks for testing. I will add it to the description

avatar MacJoom
MacJoom - comment - 7 Jun 2026

Yes that's the expected behavior. Thanks for testing. I will add it to the description. Will check if we can add a cleartext message instead.

avatar MacJoom MacJoom - change - 7 Jun 2026
The description was changed
avatar MacJoom MacJoom - edited - 7 Jun 2026
avatar MacJoom MacJoom - change - 7 Jun 2026
The description was changed
avatar MacJoom MacJoom - edited - 7 Jun 2026
avatar MacJoom MacJoom - change - 7 Jun 2026
The description was changed
avatar MacJoom MacJoom - edited - 7 Jun 2026
avatar MacJoom MacJoom - change - 7 Jun 2026
The description was changed
avatar MacJoom MacJoom - edited - 7 Jun 2026
avatar brianteeman brianteeman - test_item - 7 Jun 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Jun 2026

I have tested this item ✅ successfully on 49708d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar brianteeman
brianteeman - comment - 7 Jun 2026

I have tested this item ✅ successfully on 49708d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2026
Category Administration com_finder Language & Strings Administration com_finder Language & Strings JavaScript Repository NPM Change
avatar MacJoom
MacJoom - comment - 7 Jun 2026

Changed the js for displaying cleartext error.

avatar brianteeman brianteeman - test_item - 7 Jun 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Jun 2026

I have tested this item ✅ successfully on 49708d2

restested with much better text error instead of json


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar brianteeman
brianteeman - comment - 7 Jun 2026

I have tested this item ✅ successfully on 49708d2

restested with much better text error instead of json


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar MacJoom MacJoom - change - 7 Jun 2026
The description was changed
avatar MacJoom MacJoom - edited - 7 Jun 2026
avatar QuyTon QuyTon - test_item - 9 Jun 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 9 Jun 2026

I have tested this item ✅ successfully on c8669c3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar QuyTon
QuyTon - comment - 9 Jun 2026

I have tested this item ✅ successfully on c8669c3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar QuyTon QuyTon - alter_testresult - 9 Jun 2026 - brianteeman: Tested successfully
avatar QuyTon QuyTon - change - 9 Jun 2026
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 9 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar QuyTon
QuyTon - comment - 9 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47916.

avatar richard67 richard67 - change - 21 Jun 2026
Labels Added: RTC NPM Resource Changed bug RMDQ
avatar richard67 richard67 - change - 22 Jun 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-06-22 12:30:01
Closed_By richard67
Labels Removed: RMDQ
avatar richard67 richard67 - close - 22 Jun 2026
avatar richard67 richard67 - merge - 22 Jun 2026
avatar richard67
richard67 - comment - 22 Jun 2026

Thanks @MacJoom for this PR, @brianteeman and @QuyTon for testing, and @HLeithner for review.

Add a Comment

Login with GitHub to post a comment