[#47909] - [6.2] Implement sublevel for more than the main menu item
- Pending
- Medium
- Build: 6.2-dev
- # 47909
- Diff
- bembelimen:6.2/menu-submenu-toggle-fix
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
After #45922 fixes a lot of issues in the menu and adds proper dropdown, this PR enhance the dropdown to support more than only one level.
Testing Instructions
- Install the blog sample data
- Go to the "Main Menu Blog" menu module and change the layout to "Collapsible Default Menu"
- Check the top menu in the frontend and open sub menus
Additional checks
- Add another sub menu level
- Move the menu to the right side
- Check that all improvements from the mentioned PR still work
Actual result BEFORE applying this Pull Request
No second level menu available
Expected result AFTER applying this Pull Request
Submenus available and can be opened
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Modules Front End |
Thank you for this pull request. From a11y point of view, many levels are not recommended.
Nevertheless, the module is now accessible, thanks to @LadySolveig, so more levels can be useful.
Thanks @chmst
Personally, I would prefer a base version in the long term. One like this, that can be inherited by any menu variant and thus at least the issue of accessibility in the area of keyboard functionality is basically settled for all menus (whether frontend or backend).
This would finally have allowed the Metis menu to be removed as an unnecessary dependency. I think it was a good option to fix it in Joomla 6 in the short term using this script. But honestly, I don't see it as a really good solution for the future.
Thanks @chmst
Personally, I would prefer a base version in the long term. One like this, that can be inherited by any menu variant and thus at least the issue of accessibility in the area of keyboard functionality is basically settled for all menus (whether frontend or backend).
This would finally have allowed the Metis menu to be removed as an unnecessary dependency. I think it was a good option to fix it in Joomla 6 in the short term using this script. But honestly, I don't see it as a really good solution for the future.
Thanks @chmst
Personally, I would prefer a base version in the long term. One like this, that can be inherited by any menu variant and thus at least the issue of accessibility in the area of keyboard functionality is basically settled for all menus (whether frontend or backend).
This would finally have allowed the Metis menu to be removed as an unnecessary dependency. I think it was a good option to fix it in Joomla 6 in the short term using this script. But honestly, I don't see it as a really good solution for the future.
I have tested this item ✅ successfully on 3549a2a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47909.
I have tested this item ✅ successfully on 3549a2a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47909.
Thank you for this pull request. From a11y point of view, many levels are not recommended.
Nevertheless, the module is now accessible, thankst to @LadySolveig, so more levels can be useful.