[#47882] - [5.4] Cache fido metadata in build directory and preserve on build
- Fixed in Code Base
- 5 Jun 2026
- Medium
- Build: 5.4-dev
- # 47882
- Diff
- HLeithner:5.4/fix/fido
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This PR caches the fido metadata blob in the build folder and updates it if older then 10 days on.
On build the metadata blob will be copied to the temporary build.
Testing Instructions
- Checkout
- run php build/build.php --remote=f32e465667af5890cc6c31f276b54727fd4b63c8
Actual result BEFORE applying this Pull Request
build might be fail because restrictive rate limiting on mds.fidoalliance.org server
Expected result AFTER applying this Pull Request
Fido file will be downloaded to build/fido/fido.jwt and also to build/tmp/timestamp/build/fido/fido.jwt
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on f32e465
I've successfully tested that this PR solves the issue with the fido.jwt download failing due to the rate limiting of the download URL which has been made stricter recently qhwn it has run less than 1 hour ago on the same computer.
E.g. if you run composer install multiple times, or build packages with build/build.php multiple times (or after a previous run of composer install, the download fails without this PR.
With this PR it works because the file is cached once for each git clone and then reused.
And if that also does not work because the download URL is not available at all, you can now (with this PR) take the file from a previous patch release or nightly build and put it into the build/fido folder of your git clone, then this will be used.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47882.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-06-05 09:00:31 |
| Closed_By | ⇒ | richard67 |
Thanks @HLeithner for this PR, and @brianteeman for review.
I have tested this item ✅ successfully on f32e465
I've successfully tested that this PR solves the issue with the fido.jwt download failing due to the rate limiting of the download URL which has been made stricter recently qhwn it has run less than 1 hour ago on the same computer.
E.g. if you run
composer installmultiple times, or build packages withbuild/build.phpmultiple times (or after a previous run ofcomposer install, the download fails without this PR.With this PR it works because the file is cached once for each git clone and then reused.
And if that also does not work because the download URL is not available at all, you can now (with this PR) take the file from a previous patch release or nightly build and put it into the
build/fidofolder of your git clone, then this will be used.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47882.