[#47877] - Fix/47838 dark mode color contrast
- Pending
- Medium
- Build: 5.4-dev
- # 47877
- Diff
- Nikhil-sinhaa:fix/47838-dark-mode-color-contrast
User tests: Successful: Unsuccessful:
Pull Request resolves Fixes #47838
[x] I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
adjusted highlight colors for better contrast
Testing Instructions
-
Enable administrator dark mode
-
Create multiple versions of an article
-
Open:
Articles → Versions → Compare -
Verify:
- added text is clearly readable
- removed text is clearly readable
- contrast is improved in dark mode
- compare view remains functional in light mode
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentation
[x] No documentation changes for guide.joomla.org needed
[x] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Please use the Pull Request-Template.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-06-03 13:18:07 |
| Closed_By | ⇒ | Nikhil-sinhaa | |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2026-06-03 13:18:07 | ⇒ | |
| Closed_By | Nikhil-sinhaa | ⇒ |
| Status | New | ⇒ | Pending |
In my opinion red and green should not be used at all
Thank you for the feedback.
So should i use neutral color or use borders styling for the compare view ?
Hi @Nikhil-sinhaa, Thank you for your first time contribution.
From my POV I think this is a good starting. The colors here are currently not the best, your suggestion is better but it's not my opinion to decide though.
Anyways, this PR is a feature and it should be rebased to 6.2.
5.4 is no longer accepting features, only bug fixes.
You can also close this PR and open another one against 5.4 if it would be easier for you.
Also, you can add the target branch name in the PR title like this: [6.2] Fix dark mode color contrast.
Thanks again!
Hi @Nikhil-sinhaa, Thank you for your first time contribution.
From my POV I think this is a good starting. The colors here are currently not the best, your suggestion is better but it's not my decision though.
Anyways, this PR is a feature and it should be rebased to 6.2.
5.4 is no longer accepting features, only bug fixes.
You can also close this PR and open another one against 5.4 if it would be easier for you.
Also, you can add the target branch name in the PR title like this: [6.2] Fix dark mode color contrast.
Thanks again!
Hi @Nikhil-sinhaa, Thank you for your first time contribution.
From my POV I think this is a good starting. The colors here are currently not the best, your suggestion is better but it's not my decision though.
Anyways, this PR is a feature and it should be rebased to 6.2.
5.4 is no longer accepting features, only bug fixes.
You can also close this PR and open another one against 6.2 if it would be easier for you.
Also, you can add the target branch name in the PR title like this: [6.2] Fix dark mode color contrast.
Thanks again!
Anyways, this PR is a feature and it should be rebased to 6.2.
Not necessarily. If it fixes an accessibility (a11y) issue without introducing new functionality or changing html markup, it can be considered a bug fix and so would bebop for 5.4-dev. I think this is the case for this PR, and it is ok for 5.4.
Anyways, this PR is a feature and it should be rebased to 6.2.
Not necessarily. If it fixes an accessibility (a11y) issue without introducing new functionality or changing html markup, it can be considered a bug fix and so would be ok for 5.4-dev. I think this is the case for this PR, and it is ok for 5.4.
I agree that colour alone should not be used to indicate a state. Green=good red=bad are meaningless if you can't see the difference between those colours. But in this case they're pretty meaningless and just used to highlight so I don't see a real problem.
I always ask myself does this change make it better (not perfect, just better) than it was before and for me this pr does that.
Please use the Pull Request-Template.