[#47865] - [5.4] Joomla Alert Success
- Pending
- Medium
- Build: 5.4-dev
- # 47865
- Diff
- brianteeman:success
User tests: Successful: Unsuccessful:
Pull Request resolves #47861 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
The Joomla Alert web component adds a visually hidden text description of the icon used. Although the strings and supporting code existed for the other 4 states (error, warning, notice, message) it did not include Success
Although this was only reported in the alert displayed when a user log outs it really should have been applied to all uses of the alert which is what i have done here
Testing Instructions
On the front end of a site log in and then log out and you will see the success message. Inspect the generated code in your browser
Actual result BEFORE applying this Pull Request
you will see success
Expected result AFTER applying this Pull Request
you will see Success - note it is capitalised - that is the indication that it is using the new language string
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config com_cpanel com_installer Language & Strings Installation Layout Front End Plugins |
| Labels |
Added:
Language Change
PR-5.4-dev
|
||
Unable to download the dev package despite of passed tests. Should I wait more and visit the page later?
@brianteeman
Unable to download the dev package despite of passed tests. Should I wait more and visit the page later?
Sorry I don't know why. You can always use the update url
Sorry I don't know why. You can always use the update url
Unfortunately that will not work either. We currently have a problem with our builds, e.g. all nightly builds are failing at the moment, and possibly also the builds for PRs. The download of the fido.jwt file from https://mds.fidoalliance.org/ fails, and that causes the package build to fail.
The CMS maintenance team is informed and will work on a solution.
Thanks for that update @richard67
@tecpromotion maybe this should be for 6.2 as there is a new string - your choice