[#47864] - [6.2] Added missing admin-help.css
- Pending
- Medium
- Build: 6.2-dev
- # 47864
- Diff
- ceford:fix-help-css
User tests: Successful: Unsuccessful:
Pull Request resolves # .
I created a new Index of Help Pages but the css file needed was left out of the code already merged in 6.2-dev. This PR adds that missing css file.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Added media_source/com_admin/css/admin-help.css
Testing Instructions
Run npm ci or npm run build:css
In the Administrator menu of 6.2-dev go Help / Start Here - Joomla! Help and observe the Index of Help Pages menu
Actual result BEFORE applying this Pull Request
The indenting is wrong and the Toggle Menu button produces an obvious CSS problem.
Expected result AFTER applying this Pull Request
The menu behaves as intended.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
All tests are failing
We currently have a problem with system tests failing. Restating failed jobs helps often. I have done that for this PR here, now tests have passed.
| Title |
|
||||||
| Labels |
Added:
bug
PR-6.2-dev
|
||
I have tested this item ✅ successfully on f821c2c
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47864.
I have tested this item ✅ successfully on f821c2c
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47864.
You should delete the file at "old" place:
https://github.com/joomla/joomla-cms/blob/6.2-dev/build/media_source/com_admin/css/admin-help.css
You should delete the file at "old" place: https://github.com/joomla/joomla-cms/blob/6.2-dev/build/media_source/com_admin/css/admin-help.css
I tried that and I am now stuck in a muddle! In my local clone I deleted the build/media_source folder as the old admin-help.css was the only thing in it. When I came to commit and push the push step failed. It seems I need to first pull 4 changes from my remote fork but I don't know which command to use (or what changes will be pulled). I am offered these hints:
hint: git config pull.rebase false # merge
hint: git config pull.rebase true # rebase
hint: git config pull.ff only # fast-forward only
Can someone tell me what to do?
What is this test that is failing? I have no idea what to do about it!