bug PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 May 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

When there are no tours, then the guided tours script crashes randomly, especially on GH actions with the error:
TypeError: Cannot read properties of undefined (reading 'length')

This run here is an example:
https://github.com/joomla/joomla-cms/actions/runs/26169001264/job/77141859241?pr=47811

Testing Instructions

  • Make sure guided tours is enabled
  • Browse the back end

Actual result BEFORE applying this Pull Request

Sometimes the following error is shown:
Oh no! It looks like your tour is off track. The tour exited and cannot run.

Expected result AFTER applying this Pull Request

No error.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 21 May 2026
avatar laoneo laoneo - change - 21 May 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2026
Category JavaScript
avatar richard67
richard67 - comment - 21 May 2026

I would assume that this bug also exists for lower versions than 6.2.

avatar laoneo
laoneo - comment - 21 May 2026

I guess it happens only till the first tour is added, so it doesn't break in 6.1 or lower because they have them already. But did not check it.

avatar richard67
richard67 - comment - 21 May 2026

I guess it happens only till the first tour is added, so it doesn't break in 6.1 or lower because they have them already. But did not check it.

@laoneo That might apply to the pure core. But what if there are user-defined tours with auto start and without steps?

avatar laoneo
laoneo - comment - 21 May 2026

I don't know, perhaps can @obuisard shed some light into it. This here appeared only on 6.2-dev in system tests, so I fixed it.

avatar LadySolveig LadySolveig - test_item - 21 May 2026 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 21 May 2026

I have tested this item ✅ successfully on 5ff1c2b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47813.

avatar LadySolveig
LadySolveig - comment - 21 May 2026

I have tested this item ✅ successfully on 5ff1c2b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47813.

avatar heelc29
heelc29 - comment - 22 May 2026

The test you linked failed during the installation step for a different reason.

> Transition was skipped

image
avatar laoneo
laoneo - comment - 22 May 2026

Let's tackle that one in a different pr then.

avatar obuisard
obuisard - comment - 22 May 2026

I don't know, perhaps can @obuisard shed some light into it. This here appeared only on 6.2-dev in system tests, so I fixed it.

Humm, I have never encountered that behavior...
Definitely more solid code with your fix, thank you Allon @laoneo.

avatar MacJoom MacJoom - change - 23 May 2026
Labels Added: bug PR-6.2-dev
avatar MacJoom MacJoom - change - 24 May 2026
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-05-24 18:34:23
Closed_By MacJoom
avatar MacJoom MacJoom - close - 24 May 2026
avatar MacJoom MacJoom - merge - 24 May 2026
avatar MacJoom
MacJoom - comment - 24 May 2026

Thank you!

Add a Comment

Login with GitHub to post a comment