[#47777] - [7.0] Convert banner component to showon
- Pending
- Medium
- Build: 7.0-dev
- # 47777
- Diff
- bembelimen:7.0/banner-showon
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
I saw that com_banners has a javascript to show/hide fields. This PR gets rid of the Javascript and uses the showon functionality.
Testing Instructions
- Create a banner item
- Switch the type
Actual result BEFORE applying this Pull Request
The custom code field and the image are shwon/hidden via the JS event
Expected result AFTER applying this Pull Request
It uses the show on functionality
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners Repository NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
PR-7.0-dev
|
||
| Category | Administration com_admin com_banners Repository NPM Change JavaScript | ⇒ | Administration com_admin com_banners Repository NPM Change |
| Category | Administration com_admin com_banners Repository NPM Change | ⇒ | Administration com_admin com_banners Repository NPM Change Front End Plugins |
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Added:
Updates Requested
Removed: Conflicting Files |
||
dont you have to remove the media files in the pr?
It seems that was in the initial commit of this PR but then got lost by a later branch update because in the 6.2-dev branch the build/media_source was moved to media_source in the meantime due to the merged PR #46879 . and that has meanwhile been merged up into 7.0-dev.
@bembelimen Could you redo the deletion of the media_source/com_banners/joomla.asset.json and media_source/com_banners/js/admin-banner-edit.es6.js files in this PR?
@bembelimen Please check bembelimen#139 .
| Labels |
Removed:
Updates Requested
|
||
| Category | Administration com_admin com_banners Repository NPM Change Front End Plugins | ⇒ | Administration com_admin com_banners JavaScript Repository NPM Change Front End Plugins |
@bembelimen Please check bembelimen#139 .
Thx
@bembelimen One thing remains to be done in this PR: It needs to move the build/media_source/plg_behaviour_compat7/removed.asset.json file to media_source/plg_behaviour_compat7/removed.asset.json. I have prepared that for you: bembelimen#140
| Category | Administration com_admin com_banners Repository NPM Change Front End Plugins JavaScript | ⇒ | Administration com_admin com_banners JavaScript Repository Front End Plugins |
| Labels |
Removed:
NPM Resource Changed
|
||
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
|
||
| Category | Administration com_admin com_banners Repository Front End Plugins JavaScript | ⇒ | Administration com_admin com_banners JavaScript Repository |
This line https://github.com/joomla/joomla-cms/blob/7.0-dev/administrator/components/com_banners/tmpl/banner/edit.php#L24 must be removed to prevent error
There is no "com_banners.admin-banner-edit" asset of a "script" type in the registry because the asset is removed
dont you have to remove the media files in the pr?