Feeling Lucky
NPM Resource Changed
PR-7.0-dev
[#47777] - [7.0] Convert banner component to showon
- Pending
- Medium
- Build: 7.0-dev
- # 47777
- Diff
- bembelimen:7.0/banner-showon
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
I saw that com_banners has a javascript to show/hide fields. This PR gets rid of the Javascript and uses the showon functionality.
Testing Instructions
- Create a banner item
- Switch the type
Actual result BEFORE applying this Pull Request
The custom code field and the image are shwon/hidden via the JS event
Expected result AFTER applying this Pull Request
It uses the show on functionality
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners Repository NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
PR-7.0-dev
|
||
| Category | Administration com_admin com_banners Repository NPM Change JavaScript | ⇒ | Administration com_admin com_banners Repository NPM Change |
| Category | Administration com_admin com_banners Repository NPM Change | ⇒ | Administration com_admin com_banners Repository NPM Change Front End Plugins |
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
github-actions[bot]
- comment
- 18 May 2026
This pull request has conflicts, please resolve those before we can evaluate the pull request.
dont you have to remove the media files in the pr?