[#47751] - [5.4][webservices] PATCH user access level without rules
- Pending
- Medium
- Build: 5.4-dev
- # 47751
- Diff
- alikon:patch-2
User tests: Successful: Unsuccessful:
Pull Request resolves #47740.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Add preprocessSaveData method to handle PATCH requests when no rules in the payload.
Testing Instructions
send a PATCH to /api/index.php/v1/users/levels/{id} that omits rules
{
"title": "ccTechnician"
}Actual result BEFORE applying this Pull Request
HTTP 200, response body shows rules = [0]. The previous rules array is destroyed silently.
Expected result AFTER applying this Pull Request
only title is changed, rules is preserved.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Labels |
Added:
Webservices
PR-5.4-dev
|
||
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
I have tested this item ✅ successfully on 516d1da
Tested Successfully!
Before the patch:
{
"errors": [
{
"title": "Field required: id"
}
]
}
And after the patch:
{
"links": {
"self": "http://localhost/joomla-cms/api/index.php/v1/users/levels"
},
"data": {
"type": "levels",
"id": "7",
"attributes": {
"id": 7,
"title": "aaTechnician",
"rules": [
1,
2
]
}
}
}
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.
I have tested this item ✅ successfully on 516d1da
Tested Successfully!
Before the patch:
{
"errors": [
{
"title": "Field required: id"
}
]
}
And after the patch:
{
"links": {
"self": "http://localhost/joomla-cms/api/index.php/v1/users/levels"
},
"data": {
"type": "levels",
"id": "7",
"attributes": {
"id": 7,
"title": "aaTechnician",
"rules": [
1,
2
]
}
}
}
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.
@adarshdubey03 Can it be that you have reported your test result in the wrong PR? This one here is still draft, and your test result fits better to #47748 .
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.
| Labels |
Added:
Unit/System Tests
|
||
I have tested this item ✅ successfully on 516d1da
Tested Successfully!
Before the patch:
{
"errors": [
{
"title": "Field required: id"
}
]
}
And after the patch:
{
"links": {
"self": "http://localhost/joomla-cms/api/index.php/v1/users/levels"
},
"data": {
"type": "levels",
"id": "7",
"attributes": {
"id": 7,
"title": "aaTechnician",
"rules": [
1,
2
]
}
}
}
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.