I have tested this item ✅ successfully on 516d1da

Tested Successfully!
Before the patch:

{
"errors": [
{
"title": "Field required: id"
}
]
}
And after the patch:

{
"links": {
"self": "http://localhost/joomla-cms/api/index.php/v1/users/levels"
},
"data": {
"type": "levels",
"id": "7",
"attributes": {
"id": 7,
"title": "aaTechnician",
"rules": [
1,
2
]
}
}
}

I have tested this item ✅ successfully on 516d1da

Tested Successfully!
Before the patch:

{
"errors": [
{
"title": "Field required: id"
}
]
}
And after the patch:

{
"links": {
"self": "http://localhost/joomla-cms/api/index.php/v1/users/levels"
},
"data": {
"type": "levels",
"id": "7",
"attributes": {
"id": 7,
"title": "aaTechnician",
"rules": [
1,
2
]
}
}
}

I have tested this item ✅ successfully on 516d1da

Tested Successfully!
Before the patch:

{
"errors": [
{
"title": "Field required: id"
}
]
}
And after the patch:

{
"links": {
"self": "http://localhost/joomla-cms/api/index.php/v1/users/levels"
},
"data": {
"type": "levels",
"id": "7",
"attributes": {
"id": 7,
"title": "aaTechnician",
"rules": [
1,
2
]
}
}
}

@adarshdubey03 Can it be that you have reported your test result in the wrong PR? This one here is still draft, and your test result fits better to #47748 .

I have not tested this item.

I have not tested this item.

the test failure will be solved when pr #47748 will be merged

I have tested this item ✅ successfully on a9e23e0

I have tested this item ✅ successfully on a9e23e0

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@alikon Could you fix the conflict in file tests/System/integration/api/com_users/Levels.cy.js? It is caused by your other PR #47748 having just been merged.

yes sure i'll do it

I have tested this item ✅ successfully on 27b6eef

I was able to test this during the May 29th Friday PR Testing Session - using Postman. Thanks @alikon!

I have tested this item ✅ successfully on 27b6eef

I was able to test this during the May 29th Friday PR Testing Session - using Postman. Thanks @alikon!

RTC

RTC

I have tested this item 🔴 unsuccessfully on dd03760

✅ Final test before merge with JBT

• Used e.g. api_call "GET" "/v1/users/levels/1"
• Before PR seen api_call "PATCH" "/v1/users/levels/1" -d "{\"title\": \"IT suport\"}" is destroying rules array
• First aplied only the modified System Test file and running scripts/test 54 system api/com_users/Levels.cy.js
  • ❌ Surprisingly, all five tests passed, so they do not currently cover the actual regression.
    • The can update a users access level test does not cover the actual regression: the rules array is destroyed when updating another attribute.
    • Could the test be extended to store the complete object before patching and compare it afterwards? In this case, the test would fail before the fix and would be a real regression test.
• ✅ After applying the PR with Patch Tester, updating the title attribute correctly leaves the rules array unchanged.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.}

I have tested this item 🔴 unsuccessfully on dd03760

✅ Final test before merge with JBT

• Used e.g. api_call "GET" "/v1/users/levels/1"
• Before PR seen api_call "PATCH" "/v1/users/levels/1" -d "{\"title\": \"IT suport\"}" is destroying rules array
• First aplied only the modified System Test file and running scripts/test 54 system api/com_users/Levels.cy.js
  • ❌ Surprisingly, all five tests passed, so they do not currently cover the actual regression.
    • The can update a users access level test does not cover the actual regression: the rules array is destroyed when updating another attribute.
    • Could the test be extended to store the complete object before patching and compare it afterwards? In this case, the test would fail before the fix and would be a real regression test.
• ✅ After applying the PR with Patch Tester, updating the title attribute correctly leaves the rules array unchanged.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.}

I have tested this item 🔴 unsuccessfully on dd03760

Final test before merge with JBT

• Used e.g. api_call "GET" "/v1/users/levels/1"
• Before PR seen api_call "PATCH" "/v1/users/levels/1" -d "{\"title\": \"IT suport\"}" is destroying rules array
• First aplied only the modified System Test file and running scripts/test 54 system api/com_users/Levels.cy.js
  • ❌ Surprisingly, all five tests passed, so they do not currently cover the actual regression.
    • The can update a users access level test does not cover the actual regression: the rules array is destroyed when updating another attribute.
    • Could the test be extended to store the complete object before patching and compare it afterwards? In this case, the test would fail before the fix and would be a real regression test.
• ✅ After applying the PR with Patch Tester, updating the title attribute correctly leaves the rules array unchanged.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47751.}

back to pending

back to pending

@muhme just to understand
so the issue #47740 is fixed what are you complianing is the need of one more test to cover the scenario:
"store the complete object before patching and compare it afterwards"

I'am correct ?

@muhme just to understand
so the issue #47740 is fixed what are you complaining is the need of one more test to cover the scenario:
"store the complete object before patching and compare it afterwards"

I'am correct ?

@alikon First, thank you for your contribution and for updating the System Tests 👍

What I am asking about is, the updated can update a users access level test doesn't cover this PRs and the issue. The destroyed rules array isn't checked. The test passes even before this PR fix.

Would it make sense to extend the test by storing the complete object before the update and comparing it afterwards? In that case, the test would fail before the fix and passed afterwards.

✅ Counting still as RTC as only System Tests are changed and they passed

✅ Final Re-test before merge with JBT

• Initially, only the modified system test file was used and seen test can patch a users access level and check the rules fails
• Applied PR with patch tester
  • Updating the title attribute correctly leaves the rules array unchanged
  • All System Tests are passing

Thank you very much @alikon for your contribution and extending the System Tests. Thanks to @QuyTon and @exlemor for testing.