Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#47734] - [5.4] Do not go to database setup in installer when password has spaces at beginning/end

RTC Unit/System Tests NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
6 May 2026

Pull Request for Issue #46111, #42289 and is an alternative for #46173.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

In the installation wizard it should not be possible to navigate to the database screen when the password has spaces at the end or beginning or when the password has not at least 12 characters. This is a more lightweight alternative to #46173 which reuses the existing functionality of the validator and existing language strings.

Testing Instructions

Install Joomla with different combinations of passwords like less than 12 characters, space at the end or beginning.

Actual result BEFORE applying this Pull Request

When the password has a space at the end or beginning, then it is still possible to navigate to the database screen.

Expected result AFTER applying this Pull Request

When the password has a space at the end or beginning, then it is not possible to navigate to the database screen.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 6 May 2026
avatar laoneo laoneo - change - 6 May 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2026
Category ⇒ JavaScript Repository NPM Change Installation Layout Unit Tests
avatar laoneo laoneo - change - 6 May 2026
Labels Added: Unit/System Tests NPM Resource Changed bug PR-5.4-dev
avatar richard67
richard67 - comment - 6 May 2026

@laoneo Some of the new system tests are failing, see https://github.com/joomla/joomla-cms/actions/runs/25424969459/job/74618076354 :

Install Joomla
    1) blocks admin password with less than 12 characters
    ✓ allows admin password with 12 or more characters (2336ms)
    2) blocks admin password with spaces at the beginning
    3) blocks admin password with spaces at the end
    ✓ allows spaces in the middle of admin_password (1784ms)
    ✓ Install Joomla (11841ms)


  3 passing (35s)
  3 failing

  1) Install Joomla
       blocks admin password with less than 12 characters:
     AssertionError: Timed out retrying after 4000ms: expected '<fieldset#installStep3.j-install-step>' not to be 'visible'
      at Context.eval (webpack://joomla/./tests/System/integration/install/Installation.cy.js:17:28)

  2) Install Joomla
       blocks admin password with spaces at the beginning:
     AssertionError: Timed out retrying after 4000ms: expected '<fieldset#installStep3.j-install-step>' not to be 'visible'
      at Context.eval (webpack://joomla/./tests/System/integration/install/Installation.cy.js:54:28)

  3) Install Joomla
       blocks admin password with spaces at the end:
     AssertionError: Timed out retrying after 4000ms: expected '<fieldset#installStep3.j-install-step>' not to be 'visible'
      at Context.eval (webpack://joomla/./tests/System/integration/install/Installation.cy.js:72:28)
avatar laoneo
laoneo - comment - 6 May 2026

I know, problem is that the assets are not build and I can't have a look right now why.

avatar krishnagandhicode krishnagandhicode - test_item - 7 May 2026 - Tested successfully
avatar krishnagandhicode
krishnagandhicode - comment - 7 May 2026

I have tested this item ✅ successfully on 0853444

It perfectly passes all the test cases according to me.

Nice fix @laoneo

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.

avatar krishnagandhicode
krishnagandhicode - comment - 7 May 2026

I have tested this item ✅ successfully on 0853444

It perfectly passes all the test cases according to me.

Nice fix @laoneo

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2026
Category JavaScript Repository NPM Change Installation Layout Unit Tests ⇒ JavaScript Repository NPM Change Installation Layout
avatar laoneo laoneo - change - 7 May 2026
Labels Removed: Unit/System Tests
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2026
Category JavaScript Repository NPM Change Installation Layout ⇒ JavaScript Repository NPM Change Installation Layout Unit Tests
avatar ThomasFinnern ThomasFinnern - test_item - 8 May 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 8 May 2026

I have tested this item ✅ successfully on a7715fe

Tests tried
Could not go to next page

  • " 1234567890123456"
  • "1234567890123456 "
  • "12345678901"

Could go to next page

  • "12345678 90123456"
  • "123456789012"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.
avatar ThomasFinnern
ThomasFinnern - comment - 8 May 2026

I have tested this item ✅ successfully on a7715fe

Tests tried

  • " 1234567890123456"

  • "1234567890123456 "

  • "12345678901"
    Could not go to next page

  • "12345678 90123456"

  • "123456789012"

Could go to next page

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.
avatar ThomasFinnern
ThomasFinnern - comment - 8 May 2026

I have tested this item ✅ successfully on a7715fe

Tests tried

  • " 1234567890123456"

  • "1234567890123456 "

  • "12345678901"
    Could not go to next page

  • "12345678 90123456"

  • "123456789012"

Could go to next page

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.
avatar laoneo laoneo - change - 13 May 2026
Labels Added: Unit/System Tests
avatar laoneo laoneo - change - 13 May 2026
Status Pending ⇒ Ready to Commit
avatar laoneo
laoneo - comment - 13 May 2026

Setting to RTC as I only changed the ci.yml to cache the installation assets.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.

avatar laoneo
laoneo - comment - 13 May 2026

Setting to RTC as I only changed the ci.yml to cache the installation assets.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47734.

avatar laoneo laoneo - change - 27 May 2026
Labels Added: RTC
avatar muhme
muhme - comment - 27 May 2026

Final test before merge with JBT and simple deleting joomla-54/configuration.php file

  • Seen the problem before PR, giving password with space in the beginning, let you first continue the installation, but fails later
  • PR applied with gh pr checkout 47734 && npm run build:js
    • Spaces in the beginning or end, or password shorter than 12 chars are preventing to continue with the installation
    • Installation is possible with spaces in the middle
    • ⚠️ Tag formating from JFIELD_PASSWORD_SPACES_IN_PASSWORD in German locales is shown
      • However, it is assumed that this is not caused by this PR
      • Created #47842

👁 Please note that this PR additionally improves CI (it was needed to restore/build the installation assets, not only media to get the System Tests running).

avatar muhme muhme - change - 27 May 2026
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-05-27 09:53:26
Closed_By ⇒ muhme
avatar muhme muhme - close - 27 May 2026
avatar muhme muhme - merge - 27 May 2026
avatar muhme
muhme - comment - 27 May 2026

Thank you very much @laoneo for your contribution and also for adding five more System Tests to verify the fixed behaviour. Thanks to @RobertDeutz for review. Thanks to @krishnagandhicode and @ThomasFinnern for testing.

avatar laoneo
laoneo - comment - 27 May 2026

Kudo also to @alikon who did the base work for it.

Add a Comment

Login with GitHub to post a comment