User tests: Successful: Unsuccessful:
This PR adds SMTP OAuth2 support in Global Configuration for outgoing mail on 6.2-dev.
Implemented changes:
smtpoauth2com_configcommon and tenant-specificThe previous provider-specific legacy wrappers (m365auth, m365callback, m365checktoken) were removed/adjusted because there was no real historical route contract to preserve in core.
com_config).com_config.oauth2_state) using hash_equals.core.admin check) before writing config.smtpoauth2.This PR description now documents:
AI assistance was used to help draft/refine parts of implementation and PR text.
All code, behavior, and security assumptions were manually reviewed and tested by the author before submission.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_config Language & Strings Libraries |
Please fill out the PR form correctly, especially the AI disclaimer. Also please format your text correctly. Right now the description is hardly readable.
Okay, done. Code changes will be pulled soon
| Labels |
Added:
Language Change
PR-6.2-dev
|
||
Addressed in latest commit; thread outdated.
| Category | Administration com_config Language & Strings Libraries | ⇒ | Administration com_config Language & Strings Layout Libraries |
Added layout file for oauth2token field
All review points addressed, CI green, ready for merge.
Please fill out the PR form correctly, especially the AI disclaimer. Also please format your text correctly. Right now the description is hardly readable.
Why do you have custom routes for the different providers as legacy fallback, when they never existed in the first place? Your docblocks are incomplete. How do those callbacks against the admin com_config work, when the calling provider is not an authorised user? Seems to me as if that would fail. This needs at least documentation on how to use and test in this PR.