User tests: Successful: Unsuccessful:
This PR removes a completely pointless pseudo security-check in the TemplateHelper.
The code was supposed to check the last 256 chars of an uploaded file for HTML tags - which should removed for various reasons:
<table> tags folks, if someone has access to your PHP files, you are screwed anywaysWhy removing it now: AI agents start checking our codebase, that snippet here will very likely cause reports about the wrong offset in file_get_contents.
Code review
Code present
Code gone
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_templates |
I have tested this item ✅ successfully on accde23
I have tested this item ✅ successfully on accde23
Code review. The removed code is indeed pretty useless and reads only the last character.
I have tested this item ✅ successfully on accde23
Code review. The removed code is indeed pretty useless and reads only the last character.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.1-dev
|
||
RTC
RTC
What seems a bit strange to me is that this pr is for the 6.1-dev branch.
If there is some reason not to do it in a patch version, it should go into 6.2-dev.
But if it can be done with a patch version, it can also be done in 5.4-dev (and merged up into 6.1-dev). For me that would be ok.
@muhme @HLeithner @tecpromotion What do you think?
actually that should go into 6.2
| Title |
|
||||||
| Labels |
Added:
RTC
PR-6.2-dev
Removed: PR-6.1-dev |
||
I have tested this item ✅ successfully on accde23
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47639.