[#47632] - [6.3] Make the image list a fancy select
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 47632
- Diff
- chmst:54-fix-imagelist-multiple
User tests: Successful: Unsuccessful:
Pull Request resolves #47630
.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Testing Instructions
as described in #47630
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
In both cases, the list is a fancy select.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
I tested the pr and i have some observations, i am not sure if they are intended or not.
In multiple select mode, None Selected can be selected together with image values, and both selections are saved and still present after reload.
Single select mode works overall. But if None Selected is cleared from the chip, the field becomes temporarily empty while editing. After reload, it returns to None Selected.
@adarshdubey03 is that new or was that behaviour also present before this pr
@brianteeman The None Selected + image combination in multiple mode was already possible before this pr.
The temporary empty field in single select mode after clearing the chip is new behavior from using the fancy select ui.
| Labels |
Added:
PR-5.4-dev
|
||
@brianteeman , @adarshdubey03 What is your opinion of this change? I hide the "none selected" option for multiple selection
I need to take a closer look to understand the issue. So, off-topic: A minor typo:
Screenshot above: imagelsitno instead of imagelistno
| Labels |
Added:
UI/UX
|
||
@ChristineWk For last requested review changes, you did a slightly different change with the following commit? Could you please comment and close the requested review change?
I have tested this item ✅ successfully on ec9c99d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
I have tested this item ✅ successfully on ec9c99d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
I have tested this item ✅ successfully on ec9c99d
My first ever test, Thanks @krishnagandhicode for assistance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
I have tested this item ✅ successfully on ec9c99d
My first ever test, Thanks @krishnagandhicode for assistance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
I have tested this item ✅ successfully on ec9c99d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
I have tested this item ✅ successfully on ec9c99d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.
HLeithner
- | Title |
|
||||||
I have tested this item ✅ successfully on a773960
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47632.