[#47617] - [6.1] Fix missing closing angle bracket for fieldset in repeatable layout
- Fixed in Code Base
- 12 May 2026
- Medium
- Build: 6.1-dev
- # 47617
- Diff
- iteidrm:patch-1
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Due to changes made regarding the escaping of the $fieldset->class variable, the closing angle bracket of the fieldset tag was removed. While this is not a problem for modern browsers, it is still an error in the markup. Also, the way the check is written means that the layout always generates a class="" attribute, even when the class variable itself is empty. I have also fixed this.
Older versions than Joomla! 6.1 do not seem to be affected.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
The fieldset has a missing closing angle bracket.
Expected result AFTER applying this Pull Request
The fieldset has got a closing angle bracket.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org: n/a
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org: n/a
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
PR-6.1-dev
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on 1a36699
Fix HTML markup. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47617.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47617.
| Labels |
Added:
RTC
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-05-12 17:59:47 |
| Closed_By | ⇒ | tecpromotion |
+// phpcs:disable PSR1.Files.SideEffects
+\defined('_JEXEC') or die;
+// phpcs:enable PSR1.Files.SideEffectsHi, is there a reason why you removed the PHP Code Sniffer (PHPCS) directives / ruleset annotations? I counted approximately 2,195 instances of these within the core.
@iteidrm the reason I removed it, is because they are only needed in mixed context, having a class definition and code that gets executed. That means all our layout files don't have this phpcs rules.
I have tested this item ✅ successfully on 1a36699
Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47617.