RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
14 Apr 2026

Pull Request resolves #46495

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This PR fixes the deletion logic for update archives after automated updates. The root issue is that the update API did not correctly return the archive filename to the server.

Testing Instructions

  • Enable autoupdates in com_joomlaupdate and copy the token
  • Modify the version.php to an older version to be able to prepare an update using the autoupdate API
  • call the update preparation endpoint using curl or an http client of your choice
curl --location 'http://URL_OF_YOUR_SITe/api/index.php/v1/joomlaupdate/prepareUpdate' \
--header 'X-JUpdate-Token: YOUR_TOKEN' \
--header 'Content-Type: application/json' \
--data '{"targetVersion":"5.4.5"}'

Actual result BEFORE applying this Pull Request

  • no filename returned in response

Expected result AFTER applying this Pull Request

  • filename returned in response

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 14 Apr 2026
avatar SniperSister SniperSister - change - 14 Apr 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2026
Category Administration com_joomlaupdate
avatar SniperSister SniperSister - change - 14 Apr 2026
Title
[6..1] Fix deletion of update archive after core autoupdate
[6.1] Fix deletion of update archive after core autoupdate
avatar SniperSister SniperSister - edited - 14 Apr 2026
avatar SniperSister SniperSister - change - 14 Apr 2026
Labels Added: PR-6.1-dev
avatar SniperSister SniperSister - change - 14 Apr 2026
Title
[6.1] Fix deletion of update archive after core autoupdate
[5.4] Fix deletion of update archive after core autoupdate
avatar SniperSister SniperSister - edited - 14 Apr 2026
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2026
Category Administration com_joomlaupdate Administration com_joomlaupdate Language & Strings Installation Libraries
avatar github-actions[bot]
github-actions[bot] - comment - 14 Apr 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar richard67 richard67 - change - 14 Apr 2026
Labels Added: Language Change Conflicting Files
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2026
Category Administration com_joomlaupdate Language & Strings Installation Libraries Administration com_joomlaupdate
avatar muhme muhme - change - 16 Apr 2026
The description was changed
avatar muhme muhme - edited - 16 Apr 2026
avatar richard67 richard67 - test_item - 18 Apr 2026 - Tested successfully
avatar richard67
richard67 - comment - 18 Apr 2026

I have tested this item ✅ successfully on 0792cee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47590.

avatar alikon alikon - test_item - 22 Apr 2026 - Tested successfully
avatar alikon
alikon - comment - 22 Apr 2026

I have tested this item ✅ successfully on 0792cee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47590.

avatar alikon alikon - change - 22 Apr 2026
Status Pending Ready to Commit
avatar alikon
alikon - comment - 22 Apr 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47590.

avatar muhme muhme - change - 23 Apr 2026
Labels Added: RTC bug PR-5.4-dev
Removed: Conflicting Files PR-6.1-dev
avatar muhme
muhme - comment - 23 Apr 2026

✅ Final test before merge using JBT

  • Installed 5.4.5 on public available site
  • Modified libraries/src/Version.php const PATCH_VERSION from 5 to 4
  • Tested api/index.php/v1/joomlaupdate/prepareUpdate call
    • Seen filename is null
  • Applied patch by modifying line 572
  • Retested API call
    • Seen filename is "Joomla_5.4.5-Stable-Update_Package.zip"
avatar muhme muhme - close - 23 Apr 2026
avatar muhme muhme - merge - 23 Apr 2026
avatar muhme muhme - change - 23 Apr 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-04-23 08:46:27
Closed_By muhme
Labels Removed: Language Change
avatar muhme
muhme - comment - 23 Apr 2026

Thank you very much @SniperSister for your contribution. Thanks to @richard67 and @alikon for testing.

Add a Comment

Login with GitHub to post a comment