Pull Request resolves #47489 .

• I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Expired articles were displaying a green published icon instead
of the expired icon when selecting an article for a Single Article
menu item. Added a check for the publish_down date against the
current date before assigning the icon class, so expired articles
now correctly display the expired icon.

Testing Instructions

1. Create an article with a publish_down date in the past
2. Create a new menu item of type Single Article
3. Click Select Article to open the modal
4. Find the expired article
5. It should now show the expired icon instead of published icon

Actual result BEFORE applying this Pull Request

Expired articles show green published icon (icon-publish)

Expected result AFTER applying this Pull Request

Expired articles show expired icon (icon-expired)

Link to documentations

Please select:

• Documentation link for guide.joomla.org:

• [✅] No documentation changes for guide.joomla.org needed

• Pull Request link for manual.joomla.org:

• [✅] No documentation changes for manual.joomla.org needed