[#47491] - Fix/expired articles show published icon
- Pending
- Medium
- Build: 5.4-dev
- # 47491
- Diff
- Chitrakshi180706:fix/expired-articles-show-published-icon
User tests: Successful: Unsuccessful:
Pull Request resolves #47489 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Expired articles were displaying a green published icon instead
of the expired icon when selecting an article for a Single Article
menu item. Added a check for the publish_down date against the
current date before assigning the icon class, so expired articles
now correctly display the expired icon.
Testing Instructions
- Create an article with a publish_down date in the past
- Create a new menu item of type Single Article
- Click Select Article to open the modal
- Find the expired article
- It should now show the expired icon instead of published icon
Actual result BEFORE applying this Pull Request
Expired articles show green published icon (icon-publish)
Expected result AFTER applying this Pull Request
Expired articles show expired icon (icon-expired)
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
[✅] No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[✅] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_admin SQL |
| Category | Repository Administration com_admin SQL | ⇒ | Administration com_content |
| Labels |
Added:
PR-5.4-dev
PR-6.1-dev
|
||
Thank you for the feedback @brianteeman!
I have updated the base branch to 6.1-dev and confirmed
the AI policy check. Sorry for the confusion!
the issue also happens on 5.4
as per https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target
Thank you for the feedback @brianteeman!
I have updated the base branch to 6.1-dev and confirmed the AI policy check. Sorry for the confusion!
@Chitrakshi180706 The change of the base branch was wrong. As @alikon has mentioned in his comment, this is a bug fix for a bug which happens also on 5.4.
So this PR should be made for the 5.4-dev branch.
Maybe a rebase would be not easy fro the upper to the lower version branch, and making a new PR for 5.4-dev would be easier.
Besides this, please check my 2 review suggestions above.
Thanks in advance.
| Labels |
Added:
Updates Requested
bug
Removed: PR-5.4-dev |
||
I have tested this item ✅ successfully on 78d07ae
Not part of what was listed, but saving article first time reverted the finish publishing to the current date, but saving again kept the date in the past.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47491.
I have tested this item ✅ successfully on 78d07ae
Not part of what was listed, but saving article first time reverted the finish publishing to the current date, but saving again kept the date in the past.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47491.
I have tested this item ✅ successfully on 78d07ae
Thanks for this. Date and time showed with the patch applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47491.
I have tested this item ✅ successfully on 78d07ae
Thanks for this. Date and time showed with the patch applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47491.
Not setting RTC (ready to commit) despite of the 2 successful human tests as there are changes requested by maintainers, and the PR should be made for the 5.4-dev branch as the issue happens also in 5.4.
Your branch is 6.1 but you are trying to merge it into 5.4