[#47490] - Fix global value for Image Class missing from Figure Class in Articles site module
- Pending
- Medium
- Build: 5.4-dev
- # 47490
- Diff
- Chitrakshi180706:fix/image-class-global-value-missing
User tests: Successful: Unsuccessful:
Pull Request resolves #47335 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
When 'Use Global' is selected for Image Class in the Articles
module, the global value was not being applied to the figure tag.
The code was checking if float_intro was empty, but 'Use Global'
is not empty — it's a literal string. Fixed by also checking if
the value equals 'Use Global' and fetching the actual global
value in that case.
Testing Instructions
- Set a default Image Class in Articles e.g. "image-intro"
- Use the Articles site module
- Set Image Class to "Use Global"
- Check the HTML output
- Figure tag should now include the global image class
Actual result BEFORE applying this Pull Request
(global image class missing)Expected result AFTER applying this Pull Request
(global image class applied correctly)Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
[✅] No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[✅] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_admin SQL |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Repository Administration com_admin SQL | ⇒ | Layout |
Thank you for the feedback @brianteeman!
I have updated the base branch to 6.1-dev and confirmed
the AI policy check. Sorry for the confusion!
| Labels |
Added:
PR-6.1-dev
Removed: PR-5.4-dev |
||
I have tested this item 🔴 unsuccessfully on 88533a7
Same behaviour using Pull Request.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47490.
I have tested this item 🔴 unsuccessfully on 88533a7
Same behaviour using Pull Request.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47490.
I have tested this item 🔴 unsuccessfully on 88533a7
Cannot find anywhere to "Set Image Class" anywhere in the article module.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47490.
I have tested this item 🔴 unsuccessfully on 88533a7
Cannot find anywhere to "Set Image Class" anywhere in the article module.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47490.
@Chitrakshi180706 - Hi Chitrakshi, thank you so much for your contribution and proposal of this PR to fix Issue 47335 unfortunately, we could NOT find the Image Class in the Articles Module.
@cybersalt @exlemor you misunderstood. There is a setting for the articles component to set the default image class
In an article you will see that you can either use that global setting or change it for that article
However when the article is displayed in a module this image class (either custom or global) is not used.
Having said all of that
- I am not sure that you would want to use the image class of the article when its displayed in a module
- This PR doesnt change anything
@cybersalt @exlemor you misunderstood. There is a setting for the articles component to set the default image class
In an article you will see that you can either use that global setting or change it for that article
However when the article is displayed in a module this image class (either custom or global) is not used.
Having said all of that
- I am not sure that you would want to use the image class of the article when its displayed in a module
2. This PR doesnt change anything
@cybersalt @exlemor you misunderstood. There is a setting for the articles component to set the default image class
In an article you will see that you can either use that global setting or change it for that article
However when the article is displayed in a module this image class (either custom or global) is not used.
Having said all of that
- I am not sure that you would want to use the image class of the article when its displayed in a module
- This PR does add the image class when it is defined but does not add the global value when it is not defined
@cybersalt @exlemor you misunderstood. There is a setting for the articles component to set the default image class
In an article you will see that you can either use that global setting or change it for that article
However when the article is displayed in a module this image class (either custom or global) is not used.
Having said all of that
- I am not sure that you would want to use the image class of the article when its displayed in a module
- This PR does not change anything
Your branch is 6.1 but you are trying to merge it into 5.4
And you must complete the ai check confirmation