PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Chitrakshi180706
Chitrakshi180706
28 Mar 2026

Pull Request resolves #47335 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

When 'Use Global' is selected for Image Class in the Articles
module, the global value was not being applied to the figure tag.
The code was checking if float_intro was empty, but 'Use Global'
is not empty — it's a literal string. Fixed by also checking if
the value equals 'Use Global' and fetching the actual global
value in that case.

Testing Instructions

  1. Set a default Image Class in Articles e.g. "image-intro"
  2. Use the Articles site module
  3. Set Image Class to "Use Global"
  4. Check the HTML output
  5. Figure tag should now include the global image class

Actual result BEFORE applying this Pull Request

(global image class missing)

Expected result AFTER applying this Pull Request

(global image class applied correctly)

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • [✅] No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [✅] No documentation changes for manual.joomla.org needed

avatar Chitrakshi180706 Chitrakshi180706 - open - 28 Mar 2026
avatar Chitrakshi180706 Chitrakshi180706 - change - 28 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2026
Category Repository Administration com_admin SQL
avatar brianteeman
brianteeman - comment - 28 Mar 2026

Your branch is 6.1 but you are trying to merge it into 5.4

And you must complete the ai check confirmation

avatar Chitrakshi180706 Chitrakshi180706 - change - 28 Mar 2026
The description was changed
avatar Chitrakshi180706 Chitrakshi180706 - edited - 28 Mar 2026
avatar Chitrakshi180706 Chitrakshi180706 - change - 28 Mar 2026
Labels Added: PR-5.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2026
Category Repository Administration com_admin SQL Layout
avatar Chitrakshi180706
Chitrakshi180706 - comment - 28 Mar 2026

Thank you for the feedback @brianteeman!

I have updated the base branch to 6.1-dev and confirmed
the AI policy check. Sorry for the confusion!

Add a Comment

Login with GitHub to post a comment