Test instructions missing PR-5.4-dev AI Generated Pending

User tests: Successful: Unsuccessful:

avatar bharath110520
bharath110520
28 Mar 2026

Pull Request resolves #47445.

I read the Generative AI policy and my contribution is compatible with the policy and GNU/GPL 2 or later.


Summary of Changes

Enhances the com_menus administrator view to support URL-based filter parameters.

Currently, filter interactions rely on POST requests and session state, so filter values are not reflected in the URL. This change updates filter handling to use URL query parameters, improving usability and enabling shareable filtered views.

Key improvements include:

  • Converting filter submissions to GET-based URL updates
  • Supporting nested parameters (e.g., filter[search])
  • Handling multi-value fields and preventing duplicate parameters
  • Preserving URL hash
  • Preventing multiple overrides
  • Maintaining POST behavior for toolbar actions (delete, ordering, etc.)

Testing Instructions

  1. Go to Administrator → Menus → Manage

  2. Change filters such as:

    • Dropdown filters (e.g., Site / Administrator)
    • Search field (press Enter or click search button)
    • Column sorting
  3. Verify that:

    • The URL updates with corresponding query parameters
    • Reloading the page preserves filter state
    • Opening the URL in a new tab retains filters correctly
  4. Test toolbar actions:

    • Delete
    • Ordering

    Confirm that these actions still work correctly using POST requests.


Actual result BEFORE applying this Pull Request

  • Filter interactions used POST and session state
  • Filter values were not reflected in the URL
  • Reloading or sharing the URL did not preserve filter state

Expected result AFTER applying this Pull Request

  • Filter state is reflected in the URL using query parameters
  • Reloading or sharing the URL preserves filter state
  • URL remains clean and consistent
  • Toolbar actions continue to function correctly using POST

Link to documentations

No documentation changes for guide.joomla.org needed

No documentation changes for manual.joomla.org needed


AI usage

I have read the Generative AI policy.

This contribution was created with assistance from AI tools, but I have fully reviewed, tested, and validated the code.

I confirm that:

  • The code is understood and verified by me
  • It complies with GNU/GPL v2 or later
  • No proprietary or copyrighted code is included
  • The implementation has been tested and behaves as expected
avatar bharath110520 bharath110520 - open - 28 Mar 2026
avatar bharath110520 bharath110520 - change - 28 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2026
Category Administration com_menus
avatar BeginnerJoomlaCom
BeginnerJoomlaCom - comment - 28 Mar 2026

For PRs: Complete the Pull Request template and include test instructions.

@bharath110520 Please read: #47215

avatar LadySolveig
LadySolveig - comment - 28 Mar 2026

As you yourself have already mentioned here #47445 (comment), this PR is, if anything, an enhancement.
Please read this to help you choose the right branch
https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target

Please take another close look at whether this is consistent with the rest of the codebase and check whether this behavior actually occurs in other places as well and is expected here.
Implementing this via an inline script is definitely incorrect.

Thank you for your time and your try.
You might want to take some time beforehand to familiarize yourself more thoroughly with the current code of the project and other ressources.

avatar brianteeman
brianteeman - comment - 28 Mar 2026

This is obviously wrong

avatar bharath110520 bharath110520 - change - 29 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 29 Mar 2026
avatar bharath110520
bharath110520 - comment - 29 Mar 2026

For PRs: Complete the Pull Request template and include test instructions.

@bharath110520 Please read: #47215Thanks for the guidance. I’ve added the test instructions to the PR.

avatar bharath110520 bharath110520 - change - 29 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 29 Mar 2026
avatar BeginnerJoomlaCom
BeginnerJoomlaCom - comment - 29 Mar 2026

For PRs: Complete the Pull Request template

Please read #47215 carefully, you are missing:

ai
avatar bharath110520 bharath110520 - change - 29 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 29 Mar 2026
avatar bharath110520 bharath110520 - change - 29 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 29 Mar 2026
avatar bharath110520 bharath110520 - change - 29 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 29 Mar 2026
avatar bharath110520
bharath110520 - comment - 29 Mar 2026

Thanks for the clarification. I’ve updated the PR and added the AI usage declaration.

avatar bharath110520
bharath110520 - comment - 29 Mar 2026

As you yourself have already mentioned here #47445 (comment), this PR is, if anything, an enhancement. Please read this to help you choose the right branch https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target

Please take another close look at whether this is consistent with the rest of the codebase and check whether this behavior actually occurs in other places as well and is expected here. Implementing this via an inline script is definitely incorrect.

Thank you for your time and your try. You might want to take some time beforehand to familiarize yourself more thoroughly with the current code of the project and other ressources.

Thank you for the feedback.

I understand that implementing this via an inline script in the template is not aligned with Joomla’s architecture.

I explored this approach to validate the behavior, but I see that a proper solution would require changes at the core searchtools or framework level to maintain consistency.

I will take some time to better understand the existing implementation and architectural patterns before attempting a revised approach.

Appreciate your guidance.

avatar brianteeman
brianteeman - comment - 29 Mar 2026

Please take another close look at whether this is consistent with the rest of the codebase and check whether this behavior actually occurs in other places as well and is expected here. Implementing this via an inline script is definitely incorrect.

Thank you for your time and your try. You might want to take some time beforehand to familiarize yourself more thoroughly with the current code of the project and other ressources.

avatar bharath110520 bharath110520 - change - 30 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 30 Mar 2026
avatar bharath110520 bharath110520 - change - 30 Mar 2026
The description was changed
avatar bharath110520 bharath110520 - edited - 30 Mar 2026
avatar muhme muhme - change - 30 Mar 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-03-30 21:53:19
Closed_By muhme
Labels Added: Test instructions missing PR-5.4-dev AI Generated
avatar muhme muhme - close - 30 Mar 2026
avatar muhme
muhme - comment - 30 Mar 2026

@bharath-phenix Thank you very much for your contribution!

We have closed the issue with "In Joomla administrator lists (such as Menus, Articles, etc.), filter values are typically stored in the user session rather than in the URL. This behaviour is therefore expected and not considered a bug."

We will go ahead and close this PR.

Add a Comment

Login with GitHub to post a comment