User tests: Successful: Unsuccessful:
Pull Request resolves #47431.
This PR corrects the field order in Global Configuration --> Articles --> Editing Layout for the Images and Links section
In the component options definition, image-related fields are now placed before the link target fields:
float_introfloat_fulltexttargeta, targetb, targetcThis change only affects display order in the UI. No functionality or logic has been modified.
With both options enabled, the link target fields (targeta/targetb/targetc) appear before the image class fields (float_intro/float_fulltext), which is inconsistent with the intended Images and Links grouping.
Images and Links controls are visible.
float_intro and float_fulltext appear before targeta/targetb/targetc.
Values save and reload correctly.
No regression in article create/edit flow.
Please select:
Documentation link for guide.joomla.org:
No documentation changes needed for guide.joomla.org
Pull Request link for manual.joomla.org:
No documentation changes needed for manual.joomla.org
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_content |
Hii @BeginnerJoomlaCom Thanks for testing and confirming!! Glad it works on your side.
Hii @richard67
Just a gentle follow-up on this PR. All CI checks are green on my side, and only one status check is still pending for several hours. Could someone please take a look when convenient?
Hii @richard67 Just a gentle follow-up on this PR. All CI checks are green on my side, and only one status check is still pending for several hours. Could someone please take a look when convenient?
@SRV-KILLER09 That is the check for human tests. Each PR needs 2 successful human tests by someone else than the author of the PR. As your PR has only one test up to now, the check is pending.
I have tested this item ✅ successfully on 3969d54
I have tested this item ✅ Thankyou @SRV-KILLER09 !!
@SRV-KILLER09 Are you possibly marking test results for your own PR by using other GitGub accounts? @nikita-star-alt has no GitHub history at all, and @BeginnerJoomlaCom does not show anything public. Are you 3 really different people?
Hii..Those accounts are not mine, and I’m not using alternate accounts to mark results on my PR... The checks shown on this PR are from the repository’s CI/workflows, not personal test sign-offs from me...If helpful, maintainers can verify this via the check run details, workflow logs, and account activity metadata. & ’m happy to follow any additional verification process you want. Thankyou!
The checks shown on this PR are from the repository’s CI/workflows, not personal test sign-offs from me
@SRV-KILLER09 I know that the CI checks are from workflows.
But in addition we have the human test counter in the CI checks JTracker/HumanTestResults.
This counter is based on the test results submitted by human testers via the issue tracker, i.e. comments like this #47469 (comment) or this #47469 (comment) .
I only wanted to make sure you know the rules that a PR author can not mark successful human test results.
Sorry if I was maybe too suspicious.
But we had cases in past where we had such tricks with authors using other accounts.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Feature
PR-6.2-dev
|
||
RTC
@SRV-KILLER09 - I have been trying to test your PR and it seems that your testing instructions were probably AI generated (either that or you have a very different version of Joomla! than I have ;) ) as I can't quite match what you're asking vs what I am seeing in the Joomla Backend.
example:
Step 3: Set "Frontend Images and Links" and/or "Backend Images and Links" to "Show" feels AI generated simply because of the fact that there's no such thing as "Backend Images and Links" (at least on the 3 installation I just checked).
Step 3: Set "Frontend Images and Links" and/or "Backend Images and Links" to "Show" feels AI generated simply because of the fact that there's no such thing as "Backend Images and Links" (at least on the 3 installation I just checked).
That is indeed weird. There is not such a thing like "Backend Images and Links".
Back to pending as test can't be trusted.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
Set "Frontend Images and Links" and/or "Backend Images and Links" to "Show".
@BeginnerJoomlaCom @nikita-star-alt Could you report back how you have tested this? There is no option "Backend Images and Links".
Hi @exlemor, thank you so much! And I’m really sorry for the confusion in my earlier test instructions...I truly appreciate you pointing out the incorrect label and field order & that was actually very helpful...I think I rushed through things a bit and ended up making a basic mistake..I’ve now updated the PR description and testing steps to match the actual Joomla! UI.
Could you please check it once & confirm? & Thanks again for your patience and for helping me improve this PR!!🙏
The Issue is about Global Configuration > Articles > Editing Layout.
Originally posted by @BeginnerJoomlaCom in #47431
@exlemor @richard67 I have updated #47431 to make the Issue clear.
In Global Configuration > Articles > Editing Layout are the options:
@SRV-KILLER09 Now are the Test instructions wrong.
Are you 3 really different people? (...) @BeginnerJoomlaCom does not show anything public
@richard67 My Profile is now public.
I have not tested this item.
Changed the Result of the Test as the Test Instructions have changed in the Meantime.
| Status | Pending | ⇒ | Ready to Commit |
RTC
@BeginnerJoomlaCom I've restored your test result in the issue tracker.
I have no idea why I haven't seen the "Backend Images and Links" when I had checked last time. Pretty sure I've looked at the wrong place.
@SRV-KILLER09 If you want you can change back your testing instructions to like they were before.
As this PR has 2 successful human tests, I've set it to RTC (ready to commit).
However, when checking the issue #47431 , I see that the only thing which it solves is that it reorders the options which are only shown when either the "Frontend Images and Links" or the "Backend Images and Links" or both are selected so that image-related options come before and not after link-related options, and the only reason for that is because the 2 options are named "... Images and Links" and not "... Links and Images".
Not sure if that really is an issue. For sure it is not a bug, it's an UX issue in the best case.
At the end, the 6.2 release managers @MacJoom and @charvimehradu have to decide. I've set the "RMDQ" (release manager decision queue) label to make clear that it needs to be checked.
Said it before and will say it again. This is completely unnecessary. The options has three seperate groups of options. That is why they are seperated. The settings in the first group are not part of the second or third group. The order of these three groups makes no difference at all.
I have tested this item ✅ successfully on 3969d54
Thank you @SRV-KILLER09
The 6.0.3-Testsite was updated with the prebuilt Package Joomla_6.2.0-alpha1-dev+pr.47469-Development-Update_Package.zip.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47469.