[#4742] - If we delete all records from web link module then it displayed No Matching result in body.
- Closed
- 29 Oct 2014
- Medium
- Build: master
- # 4742
Steps to reproduce the issue
- Go to the Components-> web link.
- Delete all the records.
- Verify validation message.
Expected result
The page should display message like "No Records to display".
Actual result
It displayed No Matching result in body.
System information (as much as possible)
PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0
Additional comments
Whenever we search for something then the message "no Matching results" is displayed. So here we are not searching anything, we are deleting the record.
| Status | New | ⇒ | Confirmed |
verified.. I have tested this issue in joomla 3.3.7
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4742.
Actually, the list you see here by default is already filtered by state, only showing records which are either unpublished or published. So technically, "No Matching Results" is absolutely correct.
From a coding persperctive, there is no difference between "No records in database" to "No records found matching the filters". In both instances we get no results.
It may be possible to achieve a different message, but honestly I doubt it's worth an additional database query and an additional language string.
The bigger problem is not what we say but that we are not consistent
com_content say no matching results with no column headers
com_weblinks says no matching results with no column header
com_contact says nothing with column headers
com_newsfeeds says nothing with column headers
(Didnt check others)
It may be possible to achieve a different message, but honestly I doubt it's worth an additional database query and an additional language string.
I have same feeling with @Bakual . It is possible to use a different message, however, I don't think it is worth to write code:
I believe if we make the fix here, we will have to fix it in other core components as well
To separate the message, we will have to make an extra count query as @Bakual said or have to have an if command to check all model states and make sure they are empty
Now finishing a PR to show no matching results without headers for user notes
The bigger problem is not what we say but that we are not consistent
com_content say no matching results with no column headers
com_weblinks says no matching results with no column header
com_contact says nothing with column headers
com_newsfeeds says nothing with column headers
That would indeed a great (and easy) thing to solve
We have to correct also com_contact and com_newsfeeds
So all we have to do is changing to say no matching results with no column headers?
That would be nice, yes.
Ah true, closing this issue then since we have a PR.
zero-24
- | Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-29 09:01:23 |
| Labels |
Added:
?
|
||
Good find setting to confirmed