[#47374] - [6.2] Require --live-site option when Update Notification task runs via CLI
- Pending
- Medium
- Build: 5.4-dev
- # 47374
- Diff
- Reda-Muhamed:feature-cli-livesite-required
User tests: Successful: Unsuccessful:
Pull Request resolves #47256
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Require the --live-site option when the Update Notification task is executed via CLI.
If the option is missing, the task logs a message and exits with Status::KNOCKOUT.
Testing Instructions
- Enable System - Joomla! Update Notification plugin.
- Run:
php cli/joomla.php scheduler:run -i 3 - Verify the task exits with
Status::KNOCKOUTand logs a message. - Run:
php cli/joomla.php scheduler:run -i 3 --live-site https://example.com/ - Verify the task runs normally.
Actual result BEFORE applying this Pull Request
Running the task via CLI without --live-site generates invalid URLs like:
https://joomla.invalid/set/by/console/application/
Expected result AFTER applying this Pull Request
If --live-site is missing, the task logs a message and exits early.
If --live-site is provided, the task runs normally.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
imho i'll don't want to be so strict if the
--live-siteisn't provided a warning is enough
Thanks for the feedback!
From my understanding of @bembelimen 's comment after the maintenance meeting, the idea was to require the --live-site option and return an error when it's missing.
Since the CLI environment doesn't know the site URL by default, I thought failing early would avoid generating invalid URLs like joomla.invalid.
But I'm happy to adjust it to just log a warning if you think that's the better approach.
I'm not a maintainer, I'm a volunteer like you, so I express my opinion and, in my humble opinion, it's better to have an update notification available, even with a wrong url inside the email, rather than not having it at all and a task error
As the update message without URL does not work, it's correct to give a proper log entry and a proper exit code and not executing the task any further.
This pull request has been automatically rebased to 6.2-dev.
| Title |
|
||||||
imho i'll don't want to be so strict if the
--live-siteisn't provided a warning is enough