RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
10 Mar 2026

Pull Request resolves #44407 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Switching the Client filter (Site / Administrator) in the Menu Items view should reset the Menu filter so a valid menu can be selected for the chosen client. This currently fails because the reset logic in SearchTools.clear() only checks fields inside .js-stools-container-filters, while the client_id and menutype selectors are placed inside .js-stools-container-selector. As a result, the dependent filter is not cleared, an invalid combination may be submitted, and Joomla falls back to the Site client. This change includes .js-stools-container-selector in the reset check so the Menu filter is properly cleared when the Client filter changes.

Testing Instructions

Go to Menus and then All Menu Items in the administrator.
Ensure the filters show something like:
Client: Site
Menu: Main Menu
Change the Client filter from Site to Administrator
Repeat the same test in the opposite direction by changing Client from Administrator back to Site.

Actual result BEFORE applying this Pull Request

When changing the Client filter from Site to Administrator, the page reloads but the Client filter reverts back to Site.

Expected result AFTER applying this Pull Request

When switching the Client filter between Site and Administrator, the Menu filter is automatically reset to “Select Menu” before the form is submitted. The page reloads with the correct client selected, and the Menu dropdown then displays only the menus that belong to that client, allowing the user to switch between Site and Administrator menu items correctly.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 10 Mar 2026
avatar adarshdubey03 adarshdubey03 - change - 10 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2026
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - test_item - 10 Mar 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Mar 2026

I have tested this item ✅ successfully on 5daa258


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47352.

avatar exlemor exlemor - test_item - 10 Mar 2026 - Tested successfully
avatar exlemor
exlemor - comment - 10 Mar 2026

I have tested this item ✅ successfully on 5daa258

I have tested this successfully. Thanks @adarshdubey03 - nice to see multiple contributions from you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47352.

avatar richard67 richard67 - change - 10 Mar 2026
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.4-dev
avatar richard67
richard67 - comment - 10 Mar 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47352.

avatar richard67 richard67 - change - 10 Mar 2026
Labels Added: RTC
avatar muhme
muhme - comment - 11 Mar 2026

✅ Final test before merge using JBT

  • Installed 'Blog Sample Data', seen the Problem: Menus > Bottom Menu > Client Selector jumps back to Site, even 'Adminstrator' was selected
  • PR applied with PR's full package, installed 'Blog Sample Data', created 'Administrator Menu Test' menu with menu item
    • Issue solved, client ‘Administrator’ can now be selected permanently
    • The first client selector works with the secondary menu selector and vice versa
    • Menu items are selected accordenly to the client and menu selection
    • No errors in JS console
avatar muhme muhme - change - 11 Mar 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-03-11 06:20:43
Closed_By muhme
avatar muhme muhme - close - 11 Mar 2026
avatar muhme muhme - merge - 11 Mar 2026
avatar muhme
muhme - comment - 11 Mar 2026

Thank you @adarshdubey03 for your contribution. Thank you @brianteeman and @exlemor for testing.

Add a Comment

Login with GitHub to post a comment