NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Bodge-IT
Bodge-IT
10 Mar 2026

Upmerges from 5.4, preserving 6.0 specific fixes.

avatar Bodge-IT Bodge-IT - open - 10 Mar 2026
avatar Bodge-IT Bodge-IT - change - 10 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2026
Category Repository Administration com_admin Modules NPM Change Front End
avatar richard67
richard67 - comment - 10 Mar 2026

@LadySolveig As you have made both PRs, #47268 for 5.4-dev and #47271 for 6.0-dev: Could you check the changes here in the administrator/modules/mod_menu/tmpl/default_submenu.php file?

I think @Bodge-IT should have kept the file from 6.0-dev and have ignored all changes from 5.4-dev instead of merging up changes. Now this PR here will partly revert the changes made with PR #46550 in 6.0-dev by @bembelimen .

Or am I wrong?

avatar LadySolveig
LadySolveig - comment - 10 Mar 2026

:D When one want to make it easy for you, it somehow seems complicated too. Yes, @Bodge-IT you should have kept your version of the file - that was the point creating two differentiated PRs for the branches.

avatar Bodge-IT Bodge-IT - change - 10 Mar 2026
Labels Added: NPM Resource Changed PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2026
Category Repository Administration com_admin Modules NPM Change Front End Repository Administration Modules NPM Change Front End
avatar Bodge-IT
Bodge-IT - comment - 10 Mar 2026

@LadySolveig and @richard67 upmerge should be OK now. The changes from the 5.4 fix were automerged by vscode and we missed it. reverted now and text fixed.

avatar richard67
richard67 - comment - 10 Mar 2026

@LadySolveig and @richard67 upmerge should be OK now. The changes from the 5.4 fix were automerged by vscode and we missed it. reverted now and text fixed.

@Bodge-IT No. Your upmerge PR still shows changes for the administrator/modules/mod_menu/tmpl/default_submenu.php file, compared to 6.0-dev. See https://github.com/joomla/joomla-cms/pull/47349/changes

avatar Bodge-IT Bodge-IT - change - 10 Mar 2026
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-03-10 17:56:27
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 10 Mar 2026
avatar Bodge-IT Bodge-IT - merge - 10 Mar 2026

Add a Comment

Login with GitHub to post a comment