[#47348] - [6.1] php-cs-fixer: Check files in /build
- Pending
- Medium
- Build: 6.1-dev
- # 47348
- Diff
- joomla:6.1-php-cs-fixer-2
- Pending continuous-integration/drone/push Build is running Details
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This removes the exclusions for the files in /build and fixes the codestyle issues in them.
Testing Instructions
Nothing to test, just codereview.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
We want to check all files and not just a subset. so, yes, I think this is the right way to go.
We can remove the psr12 converter script completely, joomla is on PSR-12 and should be match already PER Coding Style.
You have the logs back in there. Saw only deleted logs folder and thought that can't really be the goal. My mistake.
If you remove the paths from the default config for cs-fixer than all developers have to make their own to run it with the dev sources right?
Do you really think this is the way to go?