User tests: Successful: Unsuccessful:
Pull Request resolves # .
Apply the patch or install the package and the sample data
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Language & Strings NPM Change |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-7.0-dev
|
||
| Category | Repository Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Language & Strings NPM Change | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Repository NPM Change JavaScript Layout |
| Labels |
Removed:
Language Change
|
||
| Category | Repository Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow NPM Change JavaScript Layout | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Repository NPM Change JavaScript |
| Category | Repository Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow NPM Change JavaScript | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Language & Strings Repository NPM Change JavaScript |
| Labels |
Added:
Language Change
|
||
| Category | Repository Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow NPM Change JavaScript Language & Strings | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Language & Strings Repository NPM Change JavaScript Libraries |
I have tested this item ✅ successfully on 42f52e7
I clicked on the first checkbox of an article and followed the instructions, and the sorting is performed correctly.
@brianteeman yes
BTW I would appreciate an accessibility test and a check on the announcements. Thanks
Better?
Looks good, thanks!
I still haven't modularize it (waiting to see the other 2-3 parts that have drag and drop)
Not important for now, can stay as you did.
It can be extended anytime later in another PR.
@brianteeman yes
BTW I would appreciate an accessibility test and a check on the announcements. Thanks
I will check tomorrow. Not looked at it too closely yet but it will need a live region for the announcement
Looks like you are missing some strings from the announcements https://dndkit.com/extend/plugins/accessibility#default-announcements and from the screen reader instructions https://dndkit.com/extend/plugins/accessibility#default-screen-reader-instructions
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
dnd works well with both mouse and keyboard
BUT when narrator is enabled it doesnt appear to work at all with the keyboard - but neither does their own demo clauderic/dnd-kit#147
you have to turn scan mode to off in narrator for it to work. i dont know if this is something obvious to screen reader users or not.
Can someone link this PR to the issue 29936
Thanks for working on it.
I have a few suggestion to make it more fun 😉
Put translation in to dedicated WebAsset as we did it for Form validation
joomla-cms/libraries/src/WebAsset/AssetItem/FormValidateAssetItem.php
Lines 38 to 45 in e2170c8
Make it work for multiple elements on the page, drop the
containerSelectorand pass the URL as data- attribute (can also pass other options as data-) kind of:It of course could be WC, but as regular container it will be more clear and reusable.
setUpSortableTable()could be publicly available so people can use it on its own. If you like.Thanks 😉