Unit/System Tests PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Mar 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

As discussed in extension developers room on mattermost, relative urls should be converted to full with SEF conversion in text.

Testing Instructions

  • Create an article
  • In the text field add a link through the menu item button
  • Save the article
  • Make an API response with a tool like postman to the url /api/index.php/v1/content/articles

Actual result BEFORE applying this Pull Request

The text field in the JSON data contains a link like menu item

Expected result AFTER applying this Pull Request

The text field in the JSON data contains a link like menu item

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 1 Mar 2026
avatar laoneo laoneo - change - 1 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2026
Category JavaScript Unit Tests
avatar bembelimen
bembelimen - comment - 1 Mar 2026

I don't think, we should use the MailTemplate class in the JSON API View. When the same code is needed/used make it global available or let the Router do things or something like that.

avatar laoneo
laoneo - comment - 1 Mar 2026

Please read the code again. This has nothing to do with MailTemplate or the Router.

avatar LadySolveig
LadySolveig - comment - 1 Mar 2026

I think what they meant to say was simply that they don't like you using the function from MailHelper here in a different context, and that it should either be removed from MailHelper and placed in a more general class or (which I find hard to imagine) duplicated again in a more general class.
I think MailTemplate was simply worded in a misleading/confusing way.

https://github.com/Digital-Peak/joomla-cms/blob/f931723e47c3cd2d36a4c0ec925406655c65ff6e/api/components/com_content/src/View/Articles/JsonapiView.php#L17

https://github.com/Digital-Peak/joomla-cms/blob/f931723e47c3cd2d36a4c0ec925406655c65ff6e/api/components/com_content/src/View/Articles/JsonapiView.php#L207

However it is implemented later, thank you in advance for the fix, it is really helpful.

avatar laoneo laoneo - change - 2 Mar 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-03-02 14:17:45
Closed_By laoneo
Labels Added: Unit/System Tests PR-6.1-dev
avatar laoneo laoneo - close - 2 Mar 2026
avatar LadySolveig
LadySolveig - comment - 3 Mar 2026

Could I please get a concrete approach to what you have in mind? I would like to see this resolved, I don't want to sink too much energy and time into such a simple task that is a matter of taste and architecture. @bembelimen @HLeithner

Add a Comment

Login with GitHub to post a comment