User tests: Successful: Unsuccessful:
As discussed in extension developers room on mattermost, relative urls should be converted to full with SEF conversion in text.
The text field in the JSON data contains a link like menu item
The text field in the JSON data contains a link like menu item
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | JavaScript Unit Tests |
Please read the code again. This has nothing to do with MailTemplate or the Router.
I think what they meant to say was simply that they don't like you using the function from MailHelper here in a different context, and that it should either be removed from MailHelper and placed in a more general class or (which I find hard to imagine) duplicated again in a more general class.
I think MailTemplate was simply worded in a misleading/confusing way.
However it is implemented later, thank you in advance for the fix, it is really helpful.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-03-02 14:17:45 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
Unit/System Tests
PR-6.1-dev
|
||
Could I please get a concrete approach to what you have in mind? I would like to see this resolved, I don't want to sink too much energy and time into such a simple task that is a matter of taste and architecture. @bembelimen @HLeithner
I don't think, we should use the MailTemplate class in the JSON API View. When the same code is needed/used make it global available or let the Router do things or something like that.