[#47245] - [5.4] Fix Mail Return-Path
- Pending
- Medium
- Build: 5.4-dev
- # 47245
- Diff
- Fedik:fix-email-return-path
User tests: Successful: Unsuccessful:
Pull Request resolves #46419 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Make sure the Sender is set correctly. As for now PHPMail trying to take the value from Server "sendmail_from" php.ini.
This leads to broken validation for SPF / DKIM settings.
Testing Instructions
Please follow:
Both should work.
Link to documentations
Please select:
- Documentation link for guide.joomla.org:
- No documentation changes for guide.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
bug
PR-5.4-dev
|
||
But this doesn't fix the problem that it will break existing configurations.
What exactly it does not fix, have a details?
Ok so external mailservers like gmail, microsoft 365 and such won't allow phpmailer on your website to send an e-mail from info@yourdomain.nl to info@yourdomain.nl (if info@yourdomain.nl is hosted on for instance gmail, microsoft 365 or other). These servers don't allow external servers to send an mail where sender = receiver. So if you have a form where you have sender the same as the receiver (for instance for the admin e-mail in rsforms, or you send a test thru com contact and the receiver is same as the sender) it is rejected because of the external mail servers policy.
This is a configuration problem. But it still breaks current systems because before the sender was never aligned so technically this sender = receiver didn't happen.
So either you would have to make this "opt in" or plan this change ahead and communicate beforehand to the users that this change is coming and they need to adjust their systems.
This has always been the case. My oldest site (circa joomla 1.0) has the from and sender set to different email address in global config for this exact reason. This used to be common knowledge but even my elephant brain forgot all about this, it's only reading it here that resurrected those brain cells.
We even documented it
Issues with the Contact form and Gmail and GoogleApps - Joomla! Documentation https://share.google/aYa5modaemandQElz
These servers don't allow external servers to send an mail where sender = receiver
I am not sure what exactly do you mean.
I am able to send the email where my email (gmail) is the same for sender and receiver.
User cannot set any From but that not new, it is blocked in many servers for a good reason.
User should set Replay-To instead.
I think you mixed "receiver" with "From".
What the PR is fixing is making sure the "From" and "Sender" is the same. Where "Sender" used for "Return-Path" in email header.
Well, not exactly, but kind of it :)
This is basically doing the same as my previous PR's? This still doesn't address the B/C Break.