RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 Feb 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Increases the inline-end padding so that the checkmark if present doesnt appear on top of the text

Testing Instructions

As this is an scss change eith npm run build:css or use a prebuilt package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 27 Feb 2026
avatar brianteeman brianteeman - change - 27 Feb 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2026
Category Repository NPM Change
avatar exlemor exlemor - test_item - 3 Mar 2026 - Tested successfully
avatar exlemor
exlemor - comment - 3 Mar 2026

I have tested this item ✅ successfully on 2239271

I have successfully tested this PR, thanks @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47244.

avatar ThomasFinnern ThomasFinnern - test_item - 6 Mar 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 6 Mar 2026

I have tested this item ✅ successfully on 2239271


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47244.

avatar richard67 richard67 - change - 6 Mar 2026
The description was changed
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.4-dev
avatar richard67
richard67 - comment - 6 Mar 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47244.

avatar richard67 richard67 - edited - 6 Mar 2026
avatar muhme muhme - change - 6 Mar 2026
Labels Added: RTC
avatar muhme
muhme - comment - 6 Mar 2026

✅ Final test before merge using JBT

  • Seen problem before PR
  • Applied PR with Patch Tester, npm run build:css and full page reload
    • The green selected check mark now has its own space
    • Is working for very long and very short category names
    • Working in dark mode
    • Working with smaller widths for mobiles
avatar muhme muhme - change - 6 Mar 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-03-06 19:03:28
Closed_By muhme
avatar muhme muhme - close - 6 Mar 2026
avatar muhme muhme - merge - 6 Mar 2026
avatar muhme
muhme - comment - 6 Mar 2026

Thank you @brianteeman for your contribution. Thank you @tecpromotion for review. Thank you @exlemor and @ThomasFinnern for testing.

avatar brianteeman
brianteeman - comment - 6 Mar 2026

Thanks

Add a Comment

Login with GitHub to post a comment