I followed the testing instructions, but I don't see that behavior. It works correctly without the PR.

I have tested this item ✅ successfully on 0592c3a

I have tested this item ✅ successfully on 0592c3a

RTC

@mariantanase I think you did not produce a recursion.

This PR needs some more testing. Please don't merge.

I have not tested this item.

Needs more tests

Back to pending due to reverted 2nd human test.

I have tested this item ✅ successfully on 0592c3a

Re-tested with different modules and articles. All fine.

RTC again

Back to pending due to requested changes. See previous code reviews. @Hackwar Could you check? Thanks in advance.

@Fedik Could you review and check if it ok now? Thanks in advance.

It is good now :)

@chmst @ChristineWk If you can find the time, could you test this PR again with the latest changes? That would be really great. Thanks for the previous tests, and thanks in advance for new ones.

I have tested this item ✅ successfully on 4f3f220

I have tested this item ✅ successfully on 4f3f220

I used {loadposition main-top} in articles and selected same position in the articles module and have seen the site 'endless loading' and crashing
Aplying the PR it is working

RTC

I have tested this item 🔴 unsuccessfully on 5a85c05

Final test before merge using JBT

• Seen site crashing with OutOfMemory with article with {loadmodule mod_articles} and site module Articles, with articles category and Introtext enabled
• Applied PR with Patch Tester, Site is no more crashing, but has PHP warnings and deprecations:

Warning: Undefined variable $match in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 145
Warning: Trying to access array offset on null in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 145
Deprecated: Using null as an array offset is deprecated, use an empty string instead in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 145
Warning: Undefined variable $match in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 149
Warning: Trying to access array offset on null in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 149
Deprecated: Using null as an array offset is deprecated, use an empty string instead in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 149
Warning: Undefined variable $match in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 177
Warning: Trying to access array offset on null in /var/www/html/plugins/content/loadmodule/src/Extension/LoadModule.php on line 177

• This was seen with PHP 8.5 (used as default), but is the same situation for PHP 8.4

Back to 'Pending', @Hackwar could you check please?

Fixed

@ThomasFinnern and @ChristineWk may I ask you to test again? It would be best to test loadposition and loadmodule.

I have tested this item ✅ successfully on ae4c185

Did test both test cases

Sorry but I diont think this is good enough. It does stop the crash but there is nothing obvious to the user why they are seeing an unprocessed {loadmodule xxx} in their module output. They will just come back and complain that the loadmodule plugin is not working and it will be very hard to debug at this point. Instead of spitting out the unprocessed string it would be better to output a meaningful message such as "recursion detected you are loading a module inside a module and we prevented that from happening so your site didnt break"

I have tested this item ✅ successfully on ae4c185

RTC

Setting RTC as it has 2 successful tests. But I've also set the RMDQ (release managers decision queue) label. We will discuss that and come back.

Discussed in maintainer meeting. Afterwards we decided to merge this PR and continue to fix with follow-up bug-issue #47544

✅ Final Test before merge with JBT

• Created a site module 'Articles', with 'Uncategorised' category, Introtext enabled and placed on main-top
• Before PR seen frontend site crashing with OutOfMemory
  • 1st article with {loadmodule mod_articles} or
  • 2nd article with {loadposition main-top}
• Applied PR with Patch Tester
  • Site is no more crashing
  • Unprocessed {loadmodule mod_articles} is shown, or {loadposition main-top} or both if both articles are enabled
  • As discussed a meaningful message should extend the unprocessed strings,
    as it will be very hard to debug -> therefore a following bug-issue #47544 was opened
  • No PHP warnings and deprecations (as in one of the previous tests)

Thank you very much @Hackwar for your contribution. Thanks to @Fedik, @brianteeman and @mariantanase for supporting. Thanks to @chmst, @ChristineWk, @ThomasFinnern and @krishnagandhicode for testing.