My concern with this is that the "offending css" has been there for 8 years - so either no one spotted this problem before OR something else has changed which is exposing this

In 5.4.3 it's the same code for padding inline end and for the padding-right: 100px I did not remove or change this, I only specified the padding inline end deeper so that it's taken into account.

The change in the original version of choices changed the specificity of the CSS definition:
Version 9.1 (the one we load in 5.4.3)
@media (width >= 640px) {
.choices__list--dropdown .choices__item--selectable {
padding-right: 100px;
}
}
Version 11.1 (the one we load in 6.0)
@media (width >= 640px) {
.choices__list--dropdown .choices__item--selectable[data-select-text], .choices__list[aria-expanded] .choices__item--selectable[data-select-text] {
padding-right: 100px;
}
}
And that is why our override
.choices .choices__list--dropdown .choices__item {
padding-inline-end: 10px;
}
doesn't work anymore

The change in the original version of choices changed the specificity of the CSS definition: Version 9.1 (the one we load in 5.4.3) @media (width >= 640px) { .choices__list--dropdown .choices__item--selectable { padding-right: 100px; } } Version 11.1 (the one we load in 6.0) @media (width >= 640px) { .choices__list--dropdown .choices__item--selectable[data-select-text], .choices__list[aria-expanded] .choices__item--selectable[data-select-text] { padding-right: 100px; } } And that is why our override .choices .choices__list--dropdown .choices__item { padding-inline-end: 10px; } doesn't work anymore

Should I then just replace the padding-inline-end: 10px; instead of adding a more specific one?

Add teh specificity in the already existent code instead of adding new one, I think the media query is not necessary.

I have tested this item 🔴 unsuccessfully on 2267095

Doesnt allow for space for the check mark

@brianteeman increased it, thanks

@brianteeman increased it, thanks

Can you please test it again @brianteeman?

I have tested this item ✅ successfully on 6b4191a

Sorry thought I had already retedted

Thanks @bembelimen for branch merge.
Thanks @coolcat-creations for fixing.
Thanks @brianteeman for testing and @drmenzelit for personal review.

@coolcat-creations @tecpromotion Is there a reason why this PR has been made for 6.1-dev despite of its title "... Bugfix ..."?

The question came up here: #47225 (comment)

See also for chosing the right base branch: https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target

@richard67 it was the correct branch as it was the only branch with the too big 100px margin. However subsequently we can see a similar problem in the 5.4 branch with a too small 10px margin. So two different problems although the checkmark issue is present in both

@richard67 it was the correct branch as it was the only branch with the too big 100px margin. However subsequently we can see a similar problem in the 5.4 branch with a too small 10px margin. So two different problems although the checkmark issue is present in both

Would be nice if someone could make a PR for 5.4-dev for that.

@richard67 done #47244