Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
16 Oct 2014

Issue

In current staging there is a new feature which allows to hide the sidebar.
For that it uses a new JS function in /media/system/core.jsnamedJoomla.toggleSidebar().
However the JLayouts don't load
core.js`. This works currently for most views because there are other places where it is loaded. But if your extension has a pure informational page like mine has, then it breaks the whole thing.

Solution

Make sure core.js is loaded by calling JHtmlBehavior::core() in the JLayout.

Testing

In Core this doesn't happen (afaik). So the easiest way would be to install an extension with the issue. You can use my extension "SermonSpeaker" (use Webinstaller or http://www.sermonspeaker.net/download/sermonspeaker-component/sermonspeaker-component-5-2-3/pkg_sermonspeaker-zip-3.html) and navigate to the "Help" view.

avatar Bakual Bakual - open - 16 Oct 2014
avatar dgt41
dgt41 - comment - 16 Oct 2014

@Bakual I think the code, related to sidebars, that exists in staging is different than that one of 3.4

avatar infograf768
infograf768 - comment - 16 Oct 2014

@Bakual
Tested with your component. Core.js is loaded>
the issue with the display of your Help comes from the css error:

#j-sidebar-container {
    margin-right: 10px;
}

should be

#j-sidebar-container {
    margin-right: 0;
}
avatar Bakual
Bakual - comment - 16 Oct 2014

@infograf768 Try with the "multilingual module" disabled. This one loads core.js as well.

@dgt41 The code in 3.3.6 is different from current staging (3.3.7-dev). But 3.4-dev should be about the same as 3.3.7-dev. The bug exists both in 3.3.7-dev and 3.4-dev.

avatar dgt41
dgt41 - comment - 16 Oct 2014

@Bakual test ok here. Side effect -> jissues doesnt have the module for tests etc. Bug?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4696.

avatar brianteeman brianteeman - change - 16 Oct 2014
Category JavaScript
avatar Bakual Bakual - change - 16 Oct 2014
Status New Pending
avatar Bakual
Bakual - comment - 16 Oct 2014

Side effect -> jissues doesnt have the module for tests etc. Bug?

Maybe, can you open a ticket in https://github.com/joomla/jissues/issues?

avatar dgt41
dgt41 - comment - 16 Oct 2014

Done!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4696.

avatar infograf768
infograf768 - comment - 17 Oct 2014

@test
OK. Merging.

avatar infograf768 infograf768 - close - 17 Oct 2014
avatar infograf768 infograf768 - change - 17 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-17 07:34:49

Add a Comment

Login with GitHub to post a comment