User tests: Successful: Unsuccessful:
Pull Request resolves #46925.
The tests-system job in ci.yml runs in a matrix with 12 combinations (6 configs × 2 browsers), but the upload-artifact step uses a static artifact name system-test-output.
With actions/upload-artifact@v4, duplicate artifact names cause upload failures (unlike v3, which merged them). Only the first completed matrix run's artifact gets saved; the rest fail.
Changes made:
system-test-output-${{ matrix.browser }}-${{ matrix.config.test_group }}Archive test results (not "results results")system-test-output-${{ matrix.browser }}-${{ matrix.config.test_group }}All 12 matrix jobs in tests-system attempt to upload an artifact with the same static name system-test-output. With upload-artifact@v4, this causes upload failures for all but the first job to complete.
Each matrix combination uploads its artifact with a unique name (e.g., system-test-output-chrome-cmysqlmax, system-test-output-edge-cpostgres), preventing upload conflicts.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository |
| Labels |
Added:
bug
PR-5.4-dev
|
||
@D3S-Gaurav When GitHub shows that the branch if not up to date, it is not a problem as long as there are no conflicts shown. So it does not need to update the branch every time. Updating the branch invalidates our human test count (which is not the case for this PR here as there were no human tests, but it might be the case for other PRs). That's why it should only be done when necessary (i.e. conflicts to be resolved) or by a maintainer who can restore the human test count after that.
@tecpromotion The „no files found“ at the end is normal? We only have screenshots when something goes wrong?
I just see in logs of other PRs that it is normal as we only have screenshots if some test failed.
@tecpromotion The „no files found“ at the end is normal? We only have screenshots when something goes wrong?
A real test for working uploads could be to make a change in the system tests so they fail with one commit in that PR and then revert that commit with another commit. The logs for the failed commit should then show the successful uploads.