Feeling Lucky
PR-5.4-dev
[#46894] - Prevent click counting for inactive banners in com_banners
- Closed
- 16 Feb 2026
- Medium
- Build: 5.4-dev
- # 46894
- Diff
- sathwikre:fix-banner-click-inactive
User tests: Successful: Unsuccessful:
Fixes #46880
Prevent click counting for unpublished or expired banners by validating
state and publishing dates in BannerModel::getItem().
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Front End com_banners |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Repository Front End com_banners | ⇒ | Front End com_banners |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-02-16 21:06:46 |
| Closed_By | ⇒ | richard67 |
richard67
- comment
- 16 Feb 2026
Thanks for pointing that out.
I see that #46881 already addresses this issue. Happy to close this PR to avoid duplication.
If helpful, I’m also happy to review or test #46881 and provide feedback.
@sathwikre 1. You could have checked if there is already a PR before making yours. You could easily see that by going to the issue on GitHub. It shows at the top if there is a PR linked to it.
- You could close this PR yourself, but you haven't.
In this way you cause additional and unnecessary work for maintainers.
We already have a pull requests for this #46881