Language Change PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar garstud
garstud
6 Feb 2026

Pull Request for Issue # 29 in the Guided Tour project : joomla-projects/guided-tours#29

Summary of Changes

Adding a new field ('url_type') to choose typical url or enter a cutom one.
Adding check validation on url on the 'option' url param to verify the component used exists or not.

Testing Instructions

  • create a new tour and enter a custom url that does'nt exists, you will show an error message when saving
  • create a new tour and enter a custom url that have an 'option=' url param that does'nt exists, you will show an error message when saving
  • create a new tour and enter a custom url that exists, you can save it and execute this new Guided tour
  • update an existing guided tour and change the 'url_type' field selected value to 'Custom' or to an existing component choice

Actual result BEFORE applying this Pull Request

The URL field is a simple url with no check on URL validation.

Expected result AFTER applying this Pull Request

You will have a list of existing url and a coice for a cutom url.
In Custom mode, you need to enter an url with an existing 'option=' that correspond to an installed component.

The new Url Type field (with a custom URL selection) :
image

A partial view of the the pre-listed items of URL type :
image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar garstud garstud - open - 6 Feb 2026
avatar garstud garstud - change - 6 Feb 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2026
Category SQL Administration com_admin Language & Strings Installation
avatar garstud garstud - change - 6 Feb 2026
The description was changed
avatar garstud garstud - edited - 6 Feb 2026
avatar obuisard obuisard - change - 6 Feb 2026
Labels Added: Language Change PR-6.1-dev
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2026
Category SQL Administration com_admin Language & Strings Installation SQL Administration com_admin Postgresql Language & Strings Installation
avatar richard67 richard67 - change - 7 Feb 2026
Title
Validation url and pre-listed components in Guided Tour
[6.1] Validation url and pre-listed components in Guided Tour
avatar richard67 richard67 - edited - 7 Feb 2026
avatar brianteeman
brianteeman - comment - 12 Feb 2026

Something is missing from this PR as the new field is never rendered

You are missing something like this from the edit.php

<?php echo $this->form->renderField('url_type'); ?>

plus quite a bit more to make it work as described

avatar brianteeman
brianteeman - comment - 12 Feb 2026

Are you sure you have committed everything as what you have here doesnt work at all

image
avatar garstud
garstud - comment - 12 Feb 2026

Are you sure you have committed everything as what you have here doesnt work at all

Well, i hope and i try to test the PR with the com_patchtester, but it seems that "apply patch" button does not work with a PR in patch mode!?
Thanks for the report, i have added some JS code to avoid this error.

avatar brianteeman
brianteeman - comment - 12 Feb 2026

I am sorry but this really doesnt work although I can finally see what it is supposed to do

The preselected menu items are very restricted bubt more importantly the validation is very limited. All of these will validate

/administrator/index.php?option=com_content
administrator/index.php?option=com_content
index.php?option=com_content
/index.php?option=com_content
/administrator/index.php?option=com_content&view=fake
/administrator/index.php?option=com_content&view=fake&context=fake

Add a Comment

Login with GitHub to post a comment