User tests: Successful: Unsuccessful:
Pull Request for Issue # 29 in the Guided Tour project : joomla-projects/guided-tours#29
Adding a new field ('url_type') to choose typical url or enter a cutom one.
Adding check validation on url on the 'option' url param to verify the component used exists or not.
The URL field is a simple url with no check on URL validation.
You will have a list of existing url and a coice for a cutom url.
In Custom mode, you need to enter an url with an existing 'option=' that correspond to an installed component.
The new Url Type field (with a custom URL selection) :

A partial view of the the pre-listed items of URL type :

Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | SQL Administration com_admin Language & Strings Installation |
| Labels |
Added:
Language Change
PR-6.1-dev
|
||
| Category | SQL Administration com_admin Language & Strings Installation | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation |
| Title |
|
||||||
Are you sure you have committed everything as what you have here doesnt work at all
Well, i hope and i try to test the PR with the com_patchtester, but it seems that "apply patch" button does not work with a PR in patch mode!?
Thanks for the report, i have added some JS code to avoid this error.
I am sorry but this really doesnt work although I can finally see what it is supposed to do
The preselected menu items are very restricted bubt more importantly the validation is very limited. All of these will validate
/administrator/index.php?option=com_content
administrator/index.php?option=com_content
index.php?option=com_content
/index.php?option=com_content
/administrator/index.php?option=com_content&view=fake
/administrator/index.php?option=com_content&view=fake&context=fake
Something is missing from this PR as the new field is never rendered
You are missing something like this from the
edit.php<?php echo $this->form->renderField('url_type'); ?>plus quite a bit more to make it work as described