[#46837] - [6.1] UX, Feature - Add possibility to disable category inheritance of showing custom fields
- Pending
- Medium
- Build: 6.1-dev
- # 46837
- Diff
- coolcat-creations:customfield-disablerecursion
User tests: Successful: Unsuccessful:
Pull Request for Issue [#45530]
Summary of Changes
Added an option to disable the inheritance of categories (inheritance is default to remain B/C)
Testing Instructions
- Before applying the patch assign a field to a specific category
- Create a new field, like always, default is Include Child Categories, field appears in subcategories
- Create a new field, in options set Include Child Categories to no, field should appear only in the parent category
- Assign the field to "all" and set Include Child Categories to no, still the field should appear everywhere
- Assign multiple Categories and Include Child Categories to no, field should appear only in the selected categories and not in their childs
- Check if the Field before applying the patch is still assigned to the child categories as it should remain the default.
- Check in Backend Category Filtering works as expected
- Check also in com_user and com_contact
Actual result BEFORE applying this Pull Request
inheritate / Including Child is default without possibility to disable this.
Expected result AFTER applying this Pull Request
Possibility to disable inheritance
Link to documentations
Please select:
- Documentation link for guide.joomla.org:
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings |
| Labels |
Added:
Language Change
PR-6.1-dev
|
||
bembelimen
- | Title |
|
||||||
I have tested this item ✅ successfully on 329b1e2
The inheritance is disabled after applying the patch.
The only thing missing is the translation of the label "COM_FIELDS_FIELD_CATEGORY_INHERITANCE_LABEL".
Tested on Joomla 6.1.0 alpha 3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.
@mariantanase did you test in en-GB? Could be the label is missing because you might test in en-US or another language? Thank you for testing.
@mariantanase did you test in en-GB? Could be the label is missing because you might test in en-US or another language? Thank you for testing.
Yes, tested with default language, en-GB
Can you please test the current state and not the single commit :) Because the language files are there (see files tab) @mariantanase Thank you
Can you please test the current state and not the single commit :) Because the language files are there (see files tab) @mariantanase Thank you
Sorry, I don't know how to test the current state. I make use of "Joomla! Patch Tester".
Can you explain ? Thanks
The language strings are wrong which is why they are not loaded
In the xml you have
COM_FIELDS_FIELD_CATEGORY_INHERITANCE_LABEL
COM_FIELDS_FIELD_CATEGORY_INHERITANCE_DESC
In the language ini you have
COM_FIELDS_FIELD_CATEGORY_RECURSIVE_DESC
COM_FIELDS_FIELD_CATEGORY_RECURSIVE_LABEL
@mariantanase did you test in en-GB? Could be the label is missing because you might test in en-US or another language? Thank you for testing.
even if you are testing in another language the strings would appear as we always fall back to en-gb when a language doesnt have a string
Ok strange must be then not pushed by mistake will take a look once back at the desk
Indeed it was my fault i did not commit this one file, now I commited and pushed it. Sorry
are you sure this is conditional check is in the correct place as we still have code in the model as highlighted in the original issue
are you sure this conditional check is in the correct place as we still have code in the model as highlighted in the original issue
@brianteeman I see what you mean. I have to fix this as the backend filtering does not work with my approach. Test have to be resetted.
| Category | Administration com_fields Language & Strings | ⇒ | Administration com_fields Language & Strings SQL Installation Postgresql |
@brianteeman @mariantanase @webnet-assmann I changed the PR and the Position of the setting.
please retest the PR. Thank you :-)
obviously this needs an update sql
obviously this needs an update sql
Again forgot to commit they were untracked ;( Sorry
| Category | Administration com_fields Language & Strings SQL Installation Postgresql | ⇒ | SQL Administration com_admin Postgresql com_fields Language & Strings Installation |
I have tested this item ✅ successfully on 88443fe
Tested correctly and works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.
I have tested this item 🔴 unsuccessfully on 88443fe
Unfortunately when I click on Content > Fields, I receive the error 500.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.
| Title |
|
||||||
I have tested this item ✅ successfully on 88443fe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.
I have tested this item 🔴 unsuccessfully on 88443feUnfortunately when I click on Content > Fields, I receive the error 500.
@mariantanase Can it be that you have tested this PR by just applying the code changes but not running the SQL statements from the update SQL script? It either needs to do that or to use the installation or update package created by our CI action (Drone) for this PR.
I have tested this item ✅ successfully on 88443fe
Thank you @richard67 . That was precisely the problem. There were no explanations on how to do this in the testing instructions. Now, after applying the patch, I have updated the database structure and no longer encounter any errors, and the behavior is as desired.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.
When I create a new custom field for users (Users > Fields > New) then the new setting "Include Subcategories" is displayed eventhough there is no category assignment field (users do not use the category system). Is it possible to hide the new field? Or is it expected?
I installed the download full-package.
When I create a new custom field for users (Users > Fields > New) then the new setting "Include Subcategories" is displayed eventhough there is no category assignment field (users do not use the category system). Is it possible to hide the new field? Or is it expected?
I installed the download full-package.
Thank you for this finding, haven't think of that
how do you get it not to show the category selector
I disabled it for where no categories exist and changed the setting name to include child categories.
how do you get no categories?
how do you get no categories?
In com_users there are no categories. Or maybe I misunderstand your question?
No that explains it perfectly - thanks
I have tested this item ✅ successfully on 1935f2b
I only have tested the part after the patch is applied (download full package).
In step 2, I was not sure what it means "parent category". If that means the currently explicitly assigned categories then it works.
When I create a new field for users (Users > Fields > New) then the new setting "Include Subcategories" is no longer visible, which is in my opinion correct.
Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.
I have tested this item ✅ successfully on ca3e29a
Tested it succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46837.