?
avatar brianteeman
brianteeman
15 Oct 2014

Steps to reproduce the issue

With 3.4-dev only resize the browser window to approximately less than 1150px and go to the article manager and observe that the new collapsible sidebar breaks the layout

Actual result

screen shot 2014-10-15 at 11 13 32

Additional comments

In 3.3.6 without the collap

avatar brianteeman brianteeman - open - 15 Oct 2014
avatar dgt41
dgt41 - comment - 15 Oct 2014
avatar Bakual
Bakual - comment - 15 Oct 2014

We could probably just hide it for smaller screens.

avatar brianteeman
brianteeman - comment - 15 Oct 2014

1150px is hardly small
On 15 Oct 2014 18:35, "Thomas Hunziker" notifications@github.com wrote:

We could probably just hide it for smaller screens.


Reply to this email directly or view it on GitHub
#4682 (comment).

avatar dgt41
dgt41 - comment - 15 Oct 2014

@Bakual We don’t have to. All is needed is hardcoding the width for #j-sidebar-container for different media queries (screen sizes) and the toggle script will change from 0 (hidden) to whatever is the case of the media query

avatar brianteeman
brianteeman - comment - 15 Oct 2014

I don't understand why with the old sidebar it would be displayed with no
problem at resolutions down to about 700px but with the new sidebar it
breaks at On 15 Oct 2014 19:00, "Dimitri Grammatiko" wrote:

@Bakual https://github.com/Bakual We don’t have to. All is needed is
hardcoding the width for #j-sidebar-container for different media queries
(screen sizes) and the toggle script will change from 0 (hidden) to
whatever is the case of the media query


Reply to this email directly or view it on GitHub
#4682 (comment).

avatar dgt41
dgt41 - comment - 15 Oct 2014
avatar brianteeman
brianteeman - comment - 15 Oct 2014

It does indeed

On 15 October 2014 21:14, Dimitri Grammatiko notifications@github.com
wrote:

removing this margin-right: 10px; here:
https://github.com/joomla/joomla-cms/blob/3.4-dev/administrator/templates/isis/less/template.less#L1050
solves the problem


Reply to this email directly or view it on GitHub
#4682 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Bakual
Bakual - comment - 16 Oct 2014

Who is doing the PR? :smile:

avatar Bakual
Bakual - comment - 16 Oct 2014

Actually, there is a PR by @dbhurley here: #4450

Can you check if the issue is also present with that PR and comment on it? So we can keep styling issues in one PR.

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar dgt41
dgt41 - comment - 16 Oct 2014

It is already reported with a comment #4450 (comment)

avatar brianteeman
brianteeman - comment - 16 Oct 2014

#4450 does not solve it - see screenshot with #4450 applied at 1150px

screen shot 2014-10-16 at 03 48 41

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4682.

avatar dgt41
dgt41 - comment - 16 Oct 2014
avatar infograf768
infograf768 - comment - 16 Oct 2014

It is OK if

#j-sidebar-container {
    margin-right: 0;
}
avatar infograf768
infograf768 - comment - 16 Oct 2014

screen shot 2014-10-16 at 10 50 13

avatar brianteeman
brianteeman - comment - 16 Oct 2014

Yes I already confirmed that the css margin change will fix it

On 16 October 2014 09:52, infograf768 notifications@github.com wrote:

[image: screen shot 2014-10-16 at 10 50 13]
https://cloud.githubusercontent.com/assets/869724/4659839/af64041e-5511-11e4-9aba-f14fc47d2f48.png


Reply to this email directly or view it on GitHub
#4682 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 16 Oct 2014

Honestly I would prefer a solution as the one in this comment: #4682 (comment)
The main difference is that in that case the side bar will have a fixed size. Which is far better IMHO than trying to figure out the menu items when the sidebar is kinda compressed due to the usage of span2 and and span 10
And as a bonus we also get nice transactions...

avatar brianteeman
brianteeman - comment - 23 Nov 2014

`closed as this is resolved elsehwere

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4682.

avatar brianteeman brianteeman - change - 23 Nov 2014
Status New Closed
avatar brianteeman brianteeman - close - 23 Nov 2014
avatar zero-24 zero-24 - close - 23 Nov 2014
avatar brianteeman brianteeman - change - 23 Nov 2014
Closed_Date 0000-00-00 00:00:00 2014-11-23 21:14:03
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 18 Apr 2018

deleted spam comment

Add a Comment

Login with GitHub to post a comment