Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#46798] - [5.4] system tests and fixes for workflows

RTC Unit/System Tests bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
31 Jan 2026

This is a continuation of #45582.

Summary of Changes

  • adds system tests (cypress) for com_workflow component
  • fix missing section of workflow in transition redirect
  • fix save transition without options (plugins)
  • prevent php warnings

Testing Instructions

enable workflow integration for articles component
image

  1. fix
  • open transition of any workflow
  • click Close or Save & Close
  • check url
  1. fix
  • disable (or exclude) all workflow plugins
  • create/save a new transition
  1. fix
  • open workflow component without specify extension /administrator/index.php?option=com_workflow&view=workflows

Actual result BEFORE applying this Pull Request

  1. fix

redirect to administrator/index.php?option=com_workflow&view=transitions&workflow_id=X&extension=com_content

  1. fix

failed to save transition
image

  1. fix

warning in php error log file
image

Expected result AFTER applying this Pull Request

  1. fix

redirect to administrator/index.php?option=com_workflow&view=transitions&workflow_id=1&extension=com_content.article

important part here is .article of extension=com_content.article

  1. fix

transition saved
image

  1. fix

no warning in php error log file

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 31 Jan 2026
avatar heelc29 heelc29 - change - 31 Jan 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2026
Category ⇒ Administration com_workflow Unit Tests Repository JavaScript
avatar heelc29 heelc29 - change - 31 Jan 2026
The description was changed
avatar heelc29 heelc29 - edited - 31 Jan 2026
avatar heelc29 heelc29 - change - 31 Jan 2026
Title
…
[5.4] system tests for workflows
[5.4] system tests and fixes for workflows
avatar heelc29 heelc29 - edited - 31 Jan 2026
avatar heelc29 heelc29 - change - 31 Jan 2026
Labels Added: Unit/System Tests PR-5.4-dev
avatar heelc29 heelc29 - change - 18 Mar 2026
Labels Added: bug
avatar muhme muhme - test_item - 14 Sep 2026 - Tested successfully
avatar muhme
muhme - comment - 14 Sep 2026

I have tested this item ✅ successfully on 74fc711

✅ Tested with JBT with workflow enabled for articles and Blog sample data installed

  • Before PR seen
    1. Seen URL after closing transition in ending with &extension=com_content
    2. Seen error 'Field 'options' doesn't have a default value' in saving new workflow step with disabled workflow plugins
    3. Seen deprecations explode(): Passing null to parameter for '/administrator/index.php?option=com_workflow&view=workflows' (and this URL also crashes with 'Extension not set.')
  • Applied PR with Patch Tester
    1. ✅ Seen URL after closing existing transition in ending with &extension=com_content.article
    • Also for 'Save & Close' existing article
    • Also for new workflow transation with 'Save' or 'Save & Close'
    • ⚠️ New bug found unrleated to this PR and opened #48453
    1. ✅ New workflow transition is saved even with the all three workflow plugins disabled
    2. ✅ No deprecations anymore for '/administrator/index.php?option=com_workflow&view=workflows'
    • But still crashes with 'Extension not set.' as the correct URL needs additionally '&extension=com_content.article' and therefore OK
    • ✅ New System Tests are running successful in current 5.4-dev branch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46798.
avatar muhme
muhme - comment - 14 Sep 2026

I have tested this item ✅ successfully on 74fc711

✅ Tested with JBT with workflow enabled for articles and Blog sample data installed

  • Before PR seen
    1. Seen URL after closing transition in ending with &extension=com_content
    2. Seen error 'Field 'options' doesn't have a default value' in saving new workflow step with disabled workflow plugins
    3. Seen deprecations explode(): Passing null to parameter for '/administrator/index.php?option=com_workflow&view=workflows' (and this URL also crashes with 'Extension not set.')
  • Applied PR with Patch Tester
    1. ✅ Seen URL after closing existing transition in ending with &extension=com_content.article
    • Also for 'Save & Close' existing article
    • Also for new workflow transation with 'Save' or 'Save & Close'
    • ⚠️ New bug found unrleated to this PR and opened #48453
    1. ✅ New workflow transition is saved even with the all three workflow plugins disabled
    2. ✅ No deprecations anymore for '/administrator/index.php?option=com_workflow&view=workflows'
    • But still crashes with 'Extension not set.' as the correct URL needs additionally '&extension=com_content.article' and therefore OK
    • ✅ New System Tests are running successful in current 5.4-dev branch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46798.
avatar muhme
muhme - comment - 14 Sep 2026

I have tested this item ✅ successfully on 74fc711

✅ Tested with JBT with workflow enabled for articles and Blog sample data installed

  • Before PR seen
    1. Seen URL after closing transition in ending with &extension=com_content
    2. Seen error 'Field 'options' doesn't have a default value' in saving new workflow step with disabled workflow plugins
    3. Seen deprecations explode(): Passing null to parameter for '/administrator/index.php?option=com_workflow&view=workflows' (and this URL also crashes with 'Extension not set.')
  • Applied PR with Patch Tester
    1. ✅ Seen URL after closing existing transition in ending with &extension=com_content.article
    • Also for 'Save & Close' existing article
    • Also for new workflow transation with 'Save' or 'Save & Close'
    • ⚠️ New bug found unrelated to this PR and opened #48453 it is not a bug it is a feature :)
    1. ✅ New workflow transition is saved even with the all three workflow plugins disabled
    2. ✅ No deprecations anymore for '/administrator/index.php?option=com_workflow&view=workflows'
    • But still crashes with 'Extension not set.' as the correct URL needs additionally '&extension=com_content.article' and therefore OK
    • ✅ New System Tests are running successful in current 5.4-dev branch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46798.
avatar muhme muhme - change - 14 Sep 2026
Status Pending ⇒ Ready to Commit
avatar muhme
muhme - comment - 14 Sep 2026

RTC as one successful test and one maintainer review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46798.

avatar muhme
muhme - comment - 14 Sep 2026

RTC as one successful test and one maintainer review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46798.

avatar richard67 richard67 - change - 15 Sep 2026
Labels Added: RTC
avatar richard67 richard67 - alter_testresult - 15 Sep 2026 - muhme: Tested successfully
avatar richard67 richard67 - alter_testresult - 15 Sep 2026 - muhme: Tested successfully
avatar richard67 richard67 - change - 15 Sep 2026
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-09-15 17:19:21
Closed_By ⇒ richard67
avatar richard67 richard67 - close - 15 Sep 2026
avatar richard67 richard67 - merge - 15 Sep 2026
avatar richard67
richard67 - comment - 15 Sep 2026

Thanks @heelc29 for this PR, @laoneo for review, and @muhme for testing.

Add a Comment

Login with GitHub to post a comment